Both Built-in and Manual saving/loading system bug

[non-nattawut]

Built-in loading got error , Manual loading got bug

For Manual Saving-Loading

Describe the bug
If load a save from manual saving variable it will only load a text state.
The Character Join , Background , Music will not load.

To Reproduce
Steps to reproduce the behavior:

1. I create a button to save-load
   
2. hit save , working OK
3. hit load , loading text only but Character Join , Background , Music will not load.

Solutions

Workaround

I tried to edit load_full_state function but got stuck on "how to join portrait inline of code"

Possible fixes

in DialogicGameHandler.gd

1. I think it is because start_timeline from event index just execute on event index that input in function
   

2. but their is something strange for me
   
   
   variable in red rectangle will empty after load by manual

For Built-in Saving-Loading

Describe the bug
saving got an error from godot engine

To Reproduce
Steps to reproduce the behavior:

1. I create a button to save-load
   
2. hit save , working OK
3. hit load got error

Solutions

Workaround&Possible fixes

I tried to look in godot repository issue
godotengine/godot#67056
godotengine/godot#68666

System (please complete the following information):

• OS: Windwos
• Godot Version: 4.0.2.stable
• Dialogic Version: Dialogic 2.0 Alpha 7 (for godot 4.0.2 stable)

PS. you can use my project to test
https://github.com/non-nattawut/Phantom-Stars

[Jowan-Spooner]

For manual save/load:

Can somewhat confirm. Can you try what effect this change has for you:
In DialogicGameHandler script in the get_full_state() method change:
return current_state_info
to
return current_state_info.duplicate(true)
It seems to be passed by reference and thus cleared afterwards.

I never saw this before because I was expecting the data to be saved in a file and loaded again inbetween saving and loading. That would obviously have created a new dictionary. Good catch.
Let me know if this helps or not!

Still investigating the error for built-in save/load

[Jowan-Spooner]

For built-in save/load:

The built in save/load DialogicCharacter error seems to be fixed by this changed (for me):
In addons/Events/Save/subsystem_save.gd script around line 80 the end of the save_file method change
file.store_var(data, true) to file.store_var(data, false)
Let me know if it helps you!

[Jowan-Spooner]

Sorry misclicked closing. Shame on me...

[non-nattawut]

Thank a lot for working hard!

For Manual Save/Load

almost everything seem working fine now, but if load state by load_full_state the Name of the character will disappear

in history is still know character name

For Built-in Save/Load

yeah I can load a save now, but got the same result as Manual Save/Load the Name of character is disappear

workaround

so I think it might be my mistake, then I tried this 2 method

1. I tried to replace dialogic addons file to older one into my project
2. I tried to use preset mode for styles and add my saving node to it

the character Name still disappear after loading

[Jowan-Spooner]

Thanks for the response! I will look into the name label going missing!

[Jowan-Spooner]

I've pushed all my fixes to main. Maybe you retry with that version. The dissappearing label should be fixed there.