Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autopauses mess up random selection modifier #1593

Closed
Jowan-Spooner opened this issue Jun 2, 2023 · 0 comments · Fixed by #1649
Closed

Autopauses mess up random selection modifier #1593

Jowan-Spooner opened this issue Jun 2, 2023 · 0 comments · Fixed by #1649
Labels
Bug 🐞 Something isn't working

Comments

@Jowan-Spooner
Copy link
Collaborator

Jowan-Spooner commented Jun 2, 2023 •
edited
Loading

The problem is that the random selection modifier uses square brackets [] like bbcode and text effects. Because autopauses tries to NOT add itself into bbcode and text effects the regex somehow messes up random selection (aka [choose/between/these] if there is any autopause-character in there.

Best solution would be to change the random selection syntax imo. Possible examples:

<Choose/Between/These>
(Choose/Between/These)
@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Jun 2, 2023
Jowan-Spooner added a commit that referenced this issue Jul 29, 2023
@Jowan-Spooner
Fix for #1635 and #1593 and random selection highlighting
d2ffd0a 
Random selection is now indicated like this <OptionA/OptionB>.
@Jowan-Spooner Jowan-Spooner linked a pull request Jul 29, 2023 that will close this issue
Fix for #1635 and #1593 and random selection highlighting #1649
Merged
Jowan-Spooner added a commit that referenced this issue Jul 30, 2023
@Jowan-Spooner
Fix for #1635 and #1593 and random selection highlighting (#1649)
668c7ae 
* Fix for #1635 and #1593 and random selection highlighting

Random selection is now indicated like this <OptionA/OptionB>.

* Update tip about random words

* Fix home page random tip button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #1635 and #1593 and random selection highlighting dialogic-godot/dialogic
1 participant
@Jowan-Spooner