Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character translations bug #1987

Closed
WladekProd opened this issue Jan 2, 2024 · 4 comments
Closed

Character translations bug #1987

WladekProd opened this issue Jan 2, 2024 · 4 comments
Labels
Bug 🐞 Something isn't working

Comments

@WladekProd
Copy link

Translations bug

Describe the bug
When using translations, if there are more than 1 character when clicking on "Update CSV files", only one character will appear in the CSV file for translation. I found that in my character file, the "_translation_id" parameter is empty. When I try to fill it in and apply the translation, a zeroing of this parameter occurs. Unable to translate more than 1 character.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Character' and create 2 characters.
  2. Go to 'Settings' -> 'Translations' and enable 'Enable Translations'.
  3. Customize the translations folder and click 'Update CSV files'.
  4. Open the file 'dialogic_character_translations.csv' in any text editor.

Expected behavior
I expected all my created characters to appear in the file so I could translate their names.

Screenshots
234534

System (please complete the following information):

  • OS: Windows 10
  • Godot Version: v4.1.3 stable
  • Dialogic Version: 2.0-Alpha-13

Solutions

Workaround
I tried changing the '_translation_id' parameter manually, deleting and re-collecting translations, and recreating the character, but none of this worked.

@CakeVR
Copy link
Collaborator

CakeVR commented Jan 2, 2024

Hello, thanks for opening this issue.

A character will be translated, if they appear in a timeline.
Please try including the character in a timeline and see if this resolves the problem.

@WladekProd
Copy link
Author

Hello, thanks for opening this issue.

A character will be translated, if they appear in a timeline. Please try including the character in a timeline and see if this resolves the problem.

In Timeline I have a dialog of 2 characters, but in the translation file only 1 character appears who starts the dialog first. The second character is not added to the file.
12

@CakeVR
Copy link
Collaborator

CakeVR commented Jan 2, 2024

Thanks, I will look into this matter.

@CakeVR
Copy link
Collaborator

CakeVR commented Jan 3, 2024

Hello, I fixed the bug! Thanks for your report.

However, due to the large amount of changes I have done to the translation system over the past weeks, you will find the fix to be part of this pull request: #1954

This branch contains the new glossary translation and the character name fix. Starting from here on, all character resource files in a project will be inserted into the character names CSV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants