-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Translation Support for Glossary #1954
Merged
Jowan-Spooner
merged 77 commits into
dialogic-godot:main
from
CakeVR:add-glossary-csv-support
Jan 30, 2024
Merged
Add Translation Support for Glossary #1954
Jowan-Spooner
merged 77 commits into
dialogic-godot:main
from
CakeVR:add-glossary-csv-support
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this prefix is missing, the files will be skipped during erasure.
…dialogic into add-glossary-csv-support
Add `translation_keys` to Glossary resource. Remove glossary in-editor help. Add property constants for Glossary resource.
Entries are saved in an array and the valid keys link to the entries via a dictionary.
They broke matching on words.
…dialogic into add-glossary-csv-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for glossary translation via the Translation setting page in Dialogic 2.
The following fixes were added:
Additional changes:
Here is an example of the newline between sections feature:
A translatable resource file is either a character, timeline, or glossary resource.
In order to minimise merge pain, I have added a fix addressing the failure of capturing all character names (#1987).
From now on, all character resource files will be picked up.
To-do: