-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choice block automatically displays “condition” settings #2272
Comments
Hmm... this is not a bug, but an intentional design decision. Any event that has settings in it's body will be opened when first created, because people often just didn't notice that the events even had expandable bodies, and also it's annoying to always have to unfold the body, especially when adding events (the body will be hidden when opening the timeline later). Maybe we should rather make the UI more clear that if nothing is entered there the condition will be considered true and thus have no effect? |
Ah that makes sense. I was confused by the UX since we weren’t using conditional logic to display the choice in our initial prototype. By the way, in what section of the documentation should there be a description of the features and use cases for each timeline block type? |
Unfortunately we have not gotten around to making documentation for all the events yet. |
I’d like to help with documentation. What is the recommended structure? |
You can learn everything about the documentation here: https://github.com/dialogic-godot/documentation/ |
Thank you. FWIW, I was working with a friend to use Dialogic in a game project and we encountered some errors where we had somehow accidentally entered some text in the condition settings which caused the timeline to keep crashing. It was a fairly opaque error which had us stumped. We ended up removing the choice from the timeline and re-adding it to get things working again. |
If you remember what you entered to cause the bug, feel free to create a bug report! |
I think we had just accidentally clicked the input and maybe hit a random letter like |
This changes the syntax of the choice event a bit: ``` - Choice Text | [if Condition] [shortcode="value"] - Choice Text | [shortcode="value"] - Choice Text ``` *The old syntax without | still works though.* This also adds a new extra_data field to choices. This data will be provided to choice buttons so they can now be uniquely identified and given arbitrary information. This would be even cooler, if the dictionary field would be nicer looking. - fixes #2286 This also makes it so you have to press a button to enable the condition on choices, which looks much better. - fixes the UX problem #2272 This also fixes a bug with visual editor fields not having the correct value if they start hidden and are then revealed by a condition changing.
I have improved the UX of the choice condition for the next version. |
The problem
Adding a choice automatically displays conditional item “if … “
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The condition should be hidden until the user clicks the disclosure triangle.
Screenshots
If applicable, add screenshots to help explain your problem.
I’m creating this issue on my mobile phone, sorry 🙂
System (please complete the following information):
Solutions
Workaround
We were able to work with the choice, but it was confusing 🫤
Possible fixes
Any idea to fix the issue or a link to the line of code that might be the cause for this problem
The text was updated successfully, but these errors were encountered: