Choice event enhancements #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dictionary is provided to the choice nodes as well and can be interpreted in any way.
This changes the shortcode regex to allow for unescaped " when the parameter value is a dictionary or array (starting and ending with {}/[]). Previously dictionaries looked absolutely terrible when used as a shortcode parameter.
Jowan-Spooner
added
Bug 🐞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the syntax of the choice event a bit:
The old syntax without | still works though.
This also adds a new extra_data field to choices. This data will be provided to choice buttons so they can now be uniquely identified and given arbitrary information. This would be even cooler, if the dictionary field would be nicer looking.
This also makes it so you have to press a button to enable the condition on choices, which looks much better.
This also fixes a bug with visual editor fields not having the correct value if they start hidden and are then revealed by a condition changing.