Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #1592

Merged
merged 4 commits into from
Jun 17, 2023
Merged

Various improvements #1592

merged 4 commits into from
Jun 17, 2023

Conversation

Jowan-Spooner
Copy link
Collaborator

@Jowan-Spooner Jowan-Spooner commented Jun 1, 2023

Part 1

  • add F2 and DELETE shortcuts to portrait list

  • add F2 shortcut to type sound mood list

  • auto-edit newly created portraits/portraitgroups

  • disabled duplicate option on portrait groups (because not working)

  • fix type in index_class.scan_for_layouts() that prevented layout description from showing as tooltip

  • make complex picker select all text on focus for quicker editing.

Part 2

  • make sure DEL shortcut for portraits only works when portrait list is focused
  • make default layout use "Fit Scale Height" for portrait containers
  • add a setting to change the default layouts size mode of portrait containers
  • make the portrait class separate from the default portrait. This should make it easier to create custom portraits. also added some more documentation comments to the DialogicPortrait class.

Part 3

  • make sure portrait completion is triggered even if text is already written behind it

  • make sure name label is shown if hide_when_empty is false

  • make sure missing default sound mood doesn't result in crash

  • add default layout name label offset setting

  • make sure portrait node is instantly removed from tree

  • fix lots of small mistakes in portrait subsystem

  • add dialogic background class that should be inherited by custom backgrounds

  • simplify default background scene and make it inherit from dialogic_background

  • add lots of settings and improvements to the RPG layout

- add F2 and DELETE shortcuts to portrait list
- add F2 shortcut to type sound mood list
- auto-edit newly created portraits/portraitgroups

- fix type in index_class.scan_for_layouts() that prevented layout description from showing as tooltip

- make complex picker select all text on focus for quicker editing.
- make sure DEL shortcut for portraits only works when portrait list is focused
- make default layout use "Fit Scale Height" for portrait containers
- add a setting to change the default layouts size mode of portrait containers
- make the portrait class separate from the default portrait.
@Jowan-Spooner Jowan-Spooner marked this pull request as draft June 2, 2023 11:55
- make sure portrait completion is triggered even if text is already written behind it
- make sure name label is shown if hide_when_empty is false
- make sure missing default sound mood doesn't result in crash
- add default layout name label offset setting
- make sure portrait node is instantly removed from tree
- fix lots of small mistakes in portrait subsystem
- add dialogic background class that should be inherited by custom backgrounds
- simplify default background scene and make it inherit from dialogic_background

- add lots of settings  and improvements to the RPG layout
@Jowan-Spooner Jowan-Spooner marked this pull request as ready for review June 17, 2023 12:24
@Jowan-Spooner Jowan-Spooner changed the title Various editor improvements Various improvements Jun 17, 2023
@Jowan-Spooner Jowan-Spooner merged commit 6b3962c into main Jun 17, 2023
@Jowan-Spooner Jowan-Spooner deleted the character-editor-improv branch August 8, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant