Ensure portrait node is removed from tree immediately #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`queue_free()` only removes the node from the tree when it is freed. This gives a problem in `change_speaker`, which assumes the first child of the portrait container is the current speaker.
vmedea
force-pushed
the
portrait-remove-fix
branch
from
7f961bc to
51177b6
Compare
vmedea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queue_free()only removes the node from the tree when it is freed (before next frame). This gives a problem inchange_speaker, which assumes the first child of the portrait container is the current speaker. So add a step to remove the node immediately.