Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor UI/UX: Floating window mode #1880

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Editor UI/UX: Floating window mode #1880

merged 3 commits into from
Dec 5, 2023

Conversation

Jowan-Spooner
Copy link
Collaborator

Initial implementation of a "floating" mode for the dialogic editor.

Known problems:

  • when in floating mode, pressing the Dialogic tab will focus the window. However it also show the main editor screen, which is just empty. Ideally this would do the same as the script tab when the script editor is floating, but it might be impossible.
  • when closing the floating window while another tab is open, both editors can be open at once (embedded)
  • floating window doesn't care for the minimum size of the controls which can lead to UI breaking.
  • dialogic doesn't remember floating state nor position. We should save both in _get_window_layout() and set them with _set_window_layout()

Would fix #1878

@Jowan-Spooner Jowan-Spooner added Approved This can be added, but is not on any roadmap yet Feature✨ Needs testing More feedback/testing would be good Not Critical 🏖 UI/UX ✏ labels Nov 6, 2023
@Jowan-Spooner Jowan-Spooner marked this pull request as ready for review December 5, 2023 17:37
@Jowan-Spooner Jowan-Spooner merged commit 79a5ae7 into main Dec 5, 2023
@Jowan-Spooner Jowan-Spooner deleted the floating-window branch December 21, 2023 10:00
Invertex pushed a commit to Invertex/dialogic that referenced this pull request Jan 26, 2024
* Initial implementation of floating window mode

* Small adjustments to opening/closing behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This can be added, but is not on any roadmap yet Feature✨ Needs testing More feedback/testing would be good Not Critical 🏖 UI/UX ✏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detachable Dialogic Window
1 participant