Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feed item pill): DLT-1916 remove dt-icon from Feed Item Pill #489

Merged
merged 3 commits into from
Sep 6, 2024
Merged

feat(feed item pill): DLT-1916 remove dt-icon from Feed Item Pill #489

merged 3 commits into from
Sep 6, 2024

Conversation

ninamarina
Copy link
Contributor

@ninamarina ninamarina commented Sep 5, 2024 •
edited
Loading

Remove dt-icon from Feed Item Pill

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

📖 Jira Ticket

DLT-1916

image

@ninamarina ninamarina force-pushed the remove/dt-icon--feed-item-pill branch 3 times, most recently from 31cbd39 to 28dd934 Compare September 5, 2024 19:27
@ninamarina ninamarina force-pushed the remove/dt-icon--feed-item-pill branch from 28dd934 to d19d7c0 Compare September 5, 2024 19:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@ninamarina ninamarina force-pushed the remove/dt-icon--feed-item-pill branch from d19d7c0 to de41a05 Compare September 5, 2024 19:30
@ninamarina ninamarina added the no-visual-test Add this tag when the PR does not need visual testing label Sep 5, 2024
@ninamarina ninamarina force-pushed the remove/dt-icon--feed-item-pill branch from de41a05 to b35793e Compare September 5, 2024 19:33
@ninamarina ninamarina marked this pull request as ready for review September 5, 2024 19:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-489/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-489/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-489/

braddialpad
braddialpad approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ninamarina ninamarina merged commit bde73c8 into remove/dt-icon Sep 6, 2024
11 checks passed
@ninamarina ninamarina deleted the remove/dt-icon--feed-item-pill branch September 6, 2024 17:48
juliodialpad pushed a commit that referenced this pull request Sep 12, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.73.0-beta.2
aadc5e9 
# [9.73.0-beta.2](dialtone/v9.73.0-beta.1...dialtone/v9.73.0-beta.2) (2024-09-12)

### Bug Fixes

* **Lint:** NO-JIRA fix linter rule for text styles ([#494](#494)) ([c6b5f3f](c6b5f3f))
* **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1))
* **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6))

### Documentation

* **Icon:** DLT-1916 update documentation to show tree shaking examples   ([#491](#491)) ([5b9d969](5b9d969))
* NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6))

### Features

* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
* **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))
juliodialpad pushed a commit that referenced this pull request Sep 12, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.159.0-beta.2
d2ff70e 
# [2.159.0-beta.2](dialtone-vue2/v2.159.0-beta.1...dialtone-vue2/v2.159.0-beta.2) (2024-09-12)

### Bug Fixes

* **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1))
* **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6))

### Documentation

* NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6))

### Features

* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
* **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))
juliodialpad pushed a commit that referenced this pull request Sep 12, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.152.0-beta.2
ddf3ddc 
# [3.152.0-beta.2](dialtone-vue3/v3.152.0-beta.1...dialtone-vue3/v3.152.0-beta.2) (2024-09-12)

### Bug Fixes

* **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1))
* **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6))

### Documentation

* NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6))

### Features

* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
* **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))
juliodialpad pushed a commit that referenced this pull request Sep 23, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.77.0-beta.1
4ce6574 
# [9.77.0-beta.1](dialtone/v9.76.0...dialtone/v9.77.0-beta.1) (2024-09-23)

### Bug Fixes

* NO-JIRA merge staging into beta ([#478](#478)) ([09f1165](09f1165))
* **Tokens:** DLT-2053 android tokens color value ([#504](#504)) ([368c9db](368c9db))

### Code Refactoring

* **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280))

### Features

* **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db))
* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad pushed a commit that referenced this pull request Sep 23, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.162.0-beta.1
09b2663 
# [2.162.0-beta.1](dialtone-vue2/v2.161.0...dialtone-vue2/v2.162.0-beta.1) (2024-09-23)

### Bug Fixes

* NO-JIRA merge staging into beta ([#478](#478)) ([09f1165](09f1165))

### Code Refactoring

* **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280))

### Features

* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad pushed a commit that referenced this pull request Sep 23, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.155.0-beta.1
0eda55d 
# [3.155.0-beta.1](dialtone-vue3/v3.154.0...dialtone-vue3/v3.155.0-beta.1) (2024-09-23)

### Bug Fixes

* NO-JIRA merge staging into beta ([#478](#478)) ([09f1165](09f1165))

### Code Refactoring

* **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280))

### Features

* **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db))
* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad pushed a commit that referenced this pull request Oct 1, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.77.0
7c959b7 
# [9.77.0](dialtone/v9.76.3...dialtone/v9.77.0) (2024-10-01)

### Code Refactoring

* **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280))

### Features

* **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db))
* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad pushed a commit that referenced this pull request Oct 1, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.162.0
5b875b7 
# [2.162.0](dialtone-vue2/v2.161.2...dialtone-vue2/v2.162.0) (2024-10-01)

### Code Refactoring

* **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280))

### Features

* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad pushed a commit that referenced this pull request Oct 1, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.155.0
402b475 
# [3.155.0](dialtone-vue3/v3.154.2...dialtone-vue3/v3.155.0) (2024-10-01)

### Code Refactoring

* **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280))

### Features

* **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db))
* **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3))
* **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8))
* **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13))
* **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

Assignees
No one assigned
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ninamarina @braddialpad