fix(tokens): DLT-2053 android tokens color value #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninamarina
changed the title
|
Please add either the |
|
✔️ Deploy previews ready! |
ninamarina
requested review from
juliodialpad,
iropolo,
francisrupert and
braddialpad
as code owners
braddialpad
reviewed
Sep 20, 2024
braddialpad
approved these changes
Sep 20, 2024
juliodialpad
pushed a commit
that referenced
this pull request
Sep 23, 2024
# [9.77.0-beta.1](dialtone/v9.76.0...dialtone/v9.77.0-beta.1) (2024-09-23) ### Bug Fixes * NO-JIRA merge staging into beta ([#478](#478)) ([09f1165](09f1165)) * **Tokens:** DLT-2053 android tokens color value ([#504](#504)) ([368c9db](368c9db)) ### Code Refactoring * **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280)) ### Features * **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db)) * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 24, 2024
## [9.76.1](dialtone/v9.76.0...dialtone/v9.76.1) (2024-09-24) ### Bug Fixes * **Tokens:** DLT-2053 android tokens color value ([#504](#504)) ([368c9db](368c9db))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 24, 2024
## [1.36.3](dialtone-tokens/v1.36.2...dialtone-tokens/v1.36.3) (2024-09-24) ### Bug Fixes * **Tokens:** DLT-2053 android tokens color value ([#504](#504)) ([368c9db](368c9db))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Android color tokens
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
DLT-2053
📖 Description
Fixes the color tokens output for Android. As an example you can check out
dtColorForegroundMuted, that before had the valueColor(0xff000000)and now has the correctColor(0x80222222).💡 Context
It started working wrong when removing token-transformer.
📷 Screenshots / GIFs
Before
Now