feat(message input): DLT-1916 remove dt-icon from message input #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninamarina
requested review from
juliodialpad,
iropolo,
francisrupert and
braddialpad
as code owners
braddialpad
reviewed
Sep 6, 2024
Comment on lines
199
to
203
| <!-- @slot Slot for send button icon --> | ||
| <slot | ||
| name="sendIcon" | ||
| :icon-size="'300'" | ||
| /> |
There was a problem hiding this comment.
This is not exactly the same way as it worked before right? If nothing is passed into the "showSend" prop or "sendIcon" slot it should render the "send" icon as default. You can do this by rendering the sendIcon within the slot. If the user wants to override it, they use the sendIcon slot
There was a problem hiding this comment.
You are right, thanks for catching this. Will fix.
There was a problem hiding this comment.
I changed it to have default content for the send icon. Also, showSendIcon will be true when there is no text since text and icon are exclusive.
ninamarina
force-pushed
the
remove/dt-icon--message-input
branch
from
10e0dfd to
22c5c8e
Compare
|
Please add either the |
|
✔️ Deploy previews ready! |
juliodialpad
approved these changes
Sep 11, 2024
juliodialpad
pushed a commit
that referenced
this pull request
Sep 12, 2024
# [9.73.0-beta.2](dialtone/v9.73.0-beta.1...dialtone/v9.73.0-beta.2) (2024-09-12) ### Bug Fixes * **Lint:** NO-JIRA fix linter rule for text styles ([#494](#494)) ([c6b5f3f](c6b5f3f)) * **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1)) * **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6)) ### Documentation * **Icon:** DLT-1916 update documentation to show tree shaking examples ([#491](#491)) ([5b9d969](5b9d969)) * NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116)) * **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 12, 2024
# [2.159.0-beta.2](dialtone-vue2/v2.159.0-beta.1...dialtone-vue2/v2.159.0-beta.2) (2024-09-12) ### Bug Fixes * **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1)) * **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6)) ### Documentation * NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116)) * **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 12, 2024
# [3.152.0-beta.2](dialtone-vue3/v3.152.0-beta.1...dialtone-vue3/v3.152.0-beta.2) (2024-09-12) ### Bug Fixes * **Scrollbar Directive:** NO-JIRA overlayscrollbars missing styles ([#493](#493)) ([d1a88e1](d1a88e1)) * **Tokens:** NO-JIRA keep references in css output ([#487](#487)) ([b019ff6](b019ff6)) ### Documentation * NO-JIRA wrong dialtone-css import on local ([da5f7d6](da5f7d6)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116)) * **Utilities:** DLT-1763 add gap utility class ([#492](#492)) ([835d06f](835d06f))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 23, 2024
# [9.77.0-beta.1](dialtone/v9.76.0...dialtone/v9.77.0-beta.1) (2024-09-23) ### Bug Fixes * NO-JIRA merge staging into beta ([#478](#478)) ([09f1165](09f1165)) * **Tokens:** DLT-2053 android tokens color value ([#504](#504)) ([368c9db](368c9db)) ### Code Refactoring * **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280)) ### Features * **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db)) * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 23, 2024
# [2.162.0-beta.1](dialtone-vue2/v2.161.0...dialtone-vue2/v2.162.0-beta.1) (2024-09-23) ### Bug Fixes * NO-JIRA merge staging into beta ([#478](#478)) ([09f1165](09f1165)) ### Code Refactoring * **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad
pushed a commit
that referenced
this pull request
Sep 23, 2024
# [3.155.0-beta.1](dialtone-vue3/v3.154.0...dialtone-vue3/v3.155.0-beta.1) (2024-09-23) ### Bug Fixes * NO-JIRA merge staging into beta ([#478](#478)) ([09f1165](09f1165)) ### Code Refactoring * **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280)) ### Features * **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db)) * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad
pushed a commit
that referenced
this pull request
Oct 1, 2024
# [9.77.0](dialtone/v9.76.3...dialtone/v9.77.0) (2024-10-01) ### Code Refactoring * **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280)) ### Features * **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db)) * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad
pushed a commit
that referenced
this pull request
Oct 1, 2024
# [2.162.0](dialtone-vue2/v2.161.2...dialtone-vue2/v2.162.0) (2024-10-01) ### Code Refactoring * **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280)) ### Features * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
juliodialpad
pushed a commit
that referenced
this pull request
Oct 1, 2024
# [3.155.0](dialtone-vue3/v3.154.2...dialtone-vue3/v3.155.0) (2024-10-01) ### Code Refactoring * **Badge, Emoji Tabset, Empty State:** remove DtIcon ([#481](#481)) ([0fa1280](0fa1280)) ### Features * **Avatar:** DLT-1916 remove dt-icon ([#466](#466)) ([6ef90db](6ef90db)) * **Avatar:** DLT-1916 remove dt-icon from Avatar vue 2 ([#474](#474)) ([e8600c3](e8600c3)) * **Feed Item Pill:** DLT-1916 remove dt-icon from Feed Item Pill ([#489](#489)) ([bde73c8](bde73c8)) * **Keyboard Shortcut To Unread Pill:** DLT-1916 remove dt-icon ([#482](#482)) ([277ae13](277ae13)) * **Message Input:** DLT-1916 remove dt-icon from message input ([#490](#490)) ([3215116](3215116))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dt-icon from message input
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
DLT-1916