fix(tokens): NO-JIRA incorrect hsl for reference tokens #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braddialpad
requested review from
juliodialpad,
iropolo,
francisrupert and
ninamarina
as code owners
|
Please add either the |
|
✔️ Deploy previews ready! |
juliodialpad
approved these changes
Oct 2, 2024
|
I'll merge this so I can test it on my branch |
juliodialpad
pushed a commit
that referenced
this pull request
Oct 7, 2024
# [9.78.0](dialtone/v9.77.0...dialtone/v9.78.0) (2024-10-07) ### Bug Fixes * **Emoji Picker:** NO-JIRA refactor fix ref reactivity in vue2 ([#523](#523)) ([f164cad](f164cad)) * **Tokens:** NO-JIRA incorrect hsl for reference tokens ([#516](#516)) ([eb4e10e](eb4e10e)) ### Features * DLT-1915 add stylelint warning when using px or rem instead of tokens ([#509](#509)) ([77212aa](77212aa))
juliodialpad
pushed a commit
that referenced
this pull request
Oct 7, 2024
## [1.36.5](dialtone-tokens/v1.36.4...dialtone-tokens/v1.36.5) (2024-10-07) ### Bug Fixes * **Tokens:** NO-JIRA incorrect hsl for reference tokens ([#516](#516)) ([eb4e10e](eb4e10e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(tokens): NO-JIRA incorrect hsl for reference tokens
Obligatory GIF (super important!)
🛠️ Type Of Change
These types will increment the version number on release:
📖 Description
Fixing a problem Julio noticed where referenced tokens were not correctly generating HSL colors because a string like
var(--dt-color-foreground-critical-strong-inverted);obviously doesn't contain any color information. Instead made the hsl reference its token instead of trying to generate new color data where it cannot.Not generating HSL for gradient because it's very abnormal and I don't even think possible
Haven't really tested this much yet, will do more testing tomorrow.