feat: DLT-1915 add stylelint warning when using px or rem instead of tokens #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninamarina
changed the title
ninamarina
requested review from
juliodialpad,
iropolo,
francisrupert and
braddialpad
as code owners
braddialpad
reviewed
Sep 26, 2024
packages/stylelint-plugin-dialtone/lib/rules/use-dialtone-tokens.js
Outdated
Show resolved
Hide resolved
|
✔️ Deploy previews ready! |
juliodialpad
pushed a commit
that referenced
this pull request
Oct 7, 2024
# [9.78.0](dialtone/v9.77.0...dialtone/v9.78.0) (2024-10-07) ### Bug Fixes * **Emoji Picker:** NO-JIRA refactor fix ref reactivity in vue2 ([#523](#523)) ([f164cad](f164cad)) * **Tokens:** NO-JIRA incorrect hsl for reference tokens ([#516](#516)) ([eb4e10e](eb4e10e)) ### Features * DLT-1915 add stylelint warning when using px or rem instead of tokens ([#509](#509)) ([77212aa](77212aa))
juliodialpad
pushed a commit
that referenced
this pull request
Oct 7, 2024
# [1.2.0](stylelint-plugin-dialtone/v1.1.0...stylelint-plugin-dialtone/v1.2.0) (2024-10-07) ### Features * DLT-1915 add stylelint warning when using px or rem instead of tokens ([#509](#509)) ([77212aa](77212aa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: DLT-1915 add stylelint warning when using px or rem instead of tokens
🛠️ Type Of Change
These types will increment the version number on release:
📖 Jira Ticket
DLT-1915
📖 Description
Adds a stylelint rule to detect the use of px or rem instead of tokens.
In the case of px there are two warnings, one suggesting the use of tokens, and another suggesting the use of rem if that is not posible.
💡 Context
We observed in the Adoption Audit that in some cases px values where used for spacing, sizing, typography instead of Dialtone tokens.
📝 Checklist
For all PRs:
🔮 Next Steps
Enable the rule in Ubervoice once its released.
📷 Screenshots / GIFs
🔗 Sources