Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DLT-2192 lsp-hover-provider #563

Merged
merged 4 commits into from
Nov 19, 2024
Merged

feat: DLT-2192 lsp-hover-provider #563

merged 4 commits into from
Nov 19, 2024

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Nov 14, 2024 •
edited
Loading

Add hover provider

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix
  • Feature
  • Performance Improvement
  • Refactor

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2192

📖 Description

  • Added onHover provider
  • Improved completion items stability

💡 Context

onHover functionality was missing.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

🔮 Next Steps

  • Improve component and tokens documentation.
  • Find a way to determine the dialtone-tokens theme that the user is using.
  • Add go-to-definition functionality.

📷 Screenshots / GIFs

Screenshot 2024-11-14 at 1 54 13 p m image image Screenshot 2024-11-14 at 1 55 41 p m Screenshot 2024-11-14 at 1 55 57 p m Screenshot 2024-11-14 at 1 56 05 p m Screenshot 2024-11-14 at 1 56 13 p m

🔗 Sources

@juliodialpad
WIP
8a4fd62 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad
add hover provider
fbce067
@juliodialpad juliodialpad self-assigned this Nov 14, 2024
@juliodialpad juliodialpad added the no-visual-test Add this tag when the PR does not need visual testing label Nov 14, 2024
@juliodialpad
Copy link
Collaborator Author

Here's the link to the extensions folder, download the latest version to test: VSCode Extensions folder

@ninamarina
Copy link
Contributor

This is amazing! Can we only print only one value if it's the same in both dark and light themes?
image

@juliodialpad
Copy link
Collaborator Author

This is amazing! Can we only print only one value if it's the same in both dark and light themes? image

That needs to be fixed in the tokens instead, those values shouldn't be included in the themes but in the base tokens instead.

That's a future fix we'll do.

@juliodialpad
add language-server to release process
f583fad 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@github-actions GitHub Actions
Copy link

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-563/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-563/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-563/

@juliodialpad juliodialpad merged commit 1bd875a into staging Nov 19, 2024
6 checks passed
@juliodialpad juliodialpad deleted the feat/lsp-hover-provider branch November 19, 2024 17:03
braddialpad pushed a commit that referenced this pull request Nov 25, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.85.0
877ce7b 
# [9.85.0](dialtone/v9.84.2...dialtone/v9.85.0) (2024-11-22)

### Bug Fixes

* DLT-2117 copy/paste on message input ([#569](#569)) ([41e836d](41e836d))

### Documentation

* NO-JIRA update LS docs ([#567](#567)) ([1ae8c82](1ae8c82))

### Features

* DLT-2192 lsp-hover-provider ([#563](#563)) ([1bd875a](1bd875a))
* **Icon:** DLT-2206 add new icon Simultaneous contact center ([#564](#564)) ([c29e044](c29e044))
braddialpad pushed a commit that referenced this pull request Nov 25, 2024
@semantic-release-bot
chore(release): NO-JIRA language-server/v1.0.0
86f5b0e 
# 1.0.0 (2024-11-22)

### Features

* DLT-1812 language server - initial implementation ([#551](#551)) ([189d40c](189d40c))
* DLT-2192 lsp-hover-provider ([#563](#563)) ([1bd875a](1bd875a))
braddialpad pushed a commit that referenced this pull request Nov 25, 2024
@semantic-release-bot
chore(release): NO-JIRA vscode-extension/v1.0.0
f3511d2 
# 1.0.0 (2024-11-22)

### Documentation

* NO-JIRA update LS docs ([#567](#567)) ([1ae8c82](1ae8c82))

### Features

* DLT-1812 language server - initial implementation ([#551](#551)) ([189d40c](189d40c))
* DLT-2192 lsp-hover-provider ([#563](#563)) ([1bd875a](1bd875a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninamarina ninamarina ninamarina approved these changes

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@braddialpad braddialpad Awaiting requested review from braddialpad braddialpad is a code owner

Assignees

@juliodialpad juliodialpad

Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliodialpad @ninamarina