Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DLT-1812 language server - initial implementation #551

Merged
merged 16 commits into from
Nov 2, 2024
Merged

feat: DLT-1812 language server - initial implementation #551

merged 16 commits into from
Nov 2, 2024

Conversation

juliodialpad
Copy link
Collaborator

@juliodialpad juliodialpad commented Oct 30, 2024 •
edited
Loading

Language Server - Initial implementation

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Feature

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1812

📖 Description

  • Added packages/language-server package which contains all the language server logic and the vscode extension code.
  • Added documentation
  • Component, Prop and Values completion
  • CSS Variable completion
  • The Extension is built with ESBuild

💡 Context

We're building a VSCode extension to help developers to autocomplete Dialtone components and CSS Variables.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

🔮 Next Steps

  • Provide hover functionality
  • Improve prop suggestion
  • Detect multi-line components
  • Publish the extension to the Visual Studio Marketplace

📷 Screenshots / GIFs

  • Component completion
    Screenshot 2024-10-30 at 12 07 28 p m

  • Property completion
    Screenshot 2024-10-30 at 12 07 46 p m

  • Property values completion
    Screenshot 2024-10-30 at 12 07 55 p m

🔗 Sources

@juliodialpad
language server initial implementation
a4098b8 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad juliodialpad self-assigned this Oct 30, 2024
@juliodialpad juliodialpad marked this pull request as ready for review November 1, 2024 20:32
braddialpad
braddialpad approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I really have no business reviewing this so I'm just gonna let you merge it. Definitely needs to be documented in the future.

pnpm-workspace.yaml
Comment on lines +5 to +7
- 'packages/*'
- 'packages/dialtone-icons/*'
- 'packages/language-server/*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the previous 'packages/**/*' cover this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was too general, I was seeing unnamed packages that I didn't knew where they were coming from, so this way is more controlled.

.vscode/extensions.json
@@ -14,6 +14,7 @@
"stylelint.vscode-stylelint",
"jock.svg",
"vitest.explorer",
"vue.volar"
"vue.volar",
"johnsoncodehk.volarjs-labs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This for volar development?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@juliodialpad
merge staging
d0c8a89 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@juliodialpad juliodialpad added the no-visual-test Add this tag when the PR does not need visual testing label Nov 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-551/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-551/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-551/

@juliodialpad juliodialpad merged commit 189d40c into staging Nov 2, 2024
9 checks passed
@juliodialpad juliodialpad deleted the feat/language-server branch November 2, 2024 00:56
braddialpad pushed a commit that referenced this pull request Nov 4, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.84.0
b734c8d 
# [9.84.0](dialtone/v9.83.2...dialtone/v9.84.0) (2024-11-04)

### Bug Fixes

* **Callbar Button With Popover:** NO-JIRA use flex-start ([#558](#558)) ([1522b52](1522b52))

### Features

* DLT-1812 language server - initial implementation ([#551](#551)) ([189d40c](189d40c))
braddialpad pushed a commit that referenced this pull request Nov 4, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-icons/v4.30.0
dd27cfa 
# [4.30.0](dialtone-icons/v4.29.0...dialtone-icons/v4.30.0) (2024-11-04)

### Features

* DLT-1812 language server - initial implementation ([#551](#551)) ([189d40c](189d40c))
braddialpad pushed a commit that referenced this pull request Nov 25, 2024
@semantic-release-bot
chore(release): NO-JIRA language-server/v1.0.0
86f5b0e 
# 1.0.0 (2024-11-22)

### Features

* DLT-1812 language server - initial implementation ([#551](#551)) ([189d40c](189d40c))
* DLT-2192 lsp-hover-provider ([#563](#563)) ([1bd875a](1bd875a))
braddialpad pushed a commit that referenced this pull request Nov 25, 2024
@semantic-release-bot
chore(release): NO-JIRA vscode-extension/v1.0.0
f3511d2 
# 1.0.0 (2024-11-22)

### Documentation

* NO-JIRA update LS docs ([#567](#567)) ([1ae8c82](1ae8c82))

### Features

* DLT-1812 language server - initial implementation ([#551](#551)) ([189d40c](189d40c))
* DLT-2192 lsp-hover-provider ([#563](#563)) ([1bd875a](1bd875a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@francisrupert francisrupert Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees

@juliodialpad juliodialpad

Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliodialpad @braddialpad