Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): DLT-2206 fix icon Simultaneous ring #579

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(icon): DLT-2206 fix icon Simultaneous ring #579

merged 1 commit into from
Dec 4, 2024

Conversation

fede-dp
Copy link
Contributor

@fede-dp fede-dp commented Dec 3, 2024 •
edited
Loading

feat(icon): DLT-2206 fix icon Simultaneous ring -

Obligatory GIF (super important!)

Obligatory GIF

📖 Description

We outline stroke the icon to be render properly

💡 Context

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

@fede-dp fede-dp added the no-visual-test Add this tag when the PR does not need visual testing label Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-579/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-579/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-579/

@fede-dp fede-dp marked this pull request as ready for review December 3, 2024 20:59
braddialpad
braddialpad approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in light and dark, seems to be working well.

@francisrupert francisrupert changed the title feat(icon): DLT-2206 fix icon Simultaneous ring fix(icon): DLT-2206 fix icon Simultaneous ring Dec 3, 2024
@fede-dp fede-dp merged commit 1435dbd into staging Dec 4, 2024
8 checks passed
@fede-dp fede-dp deleted the simultanieous-call-icon branch December 4, 2024 12:29
braddialpad pushed a commit that referenced this pull request Dec 10, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.86.2
75fd9f2 
## [9.86.2](dialtone/v9.86.1...dialtone/v9.86.2) (2024-12-10)

### Bug Fixes

* **Icon:** DLT-2206 fix icon Simultaneous ring ([#579](#579)) ([1435dbd](1435dbd))

### Code Refactoring

* DLT-2122 move css out of recipes ([#577](#577)) ([75d5a0b](75d5a0b))
braddialpad pushed a commit that referenced this pull request Dec 10, 2024
@semantic-release-bot
chore(release): NO-JIRA dialtone-icons/v4.31.2
4a42bf4 
## [4.31.2](dialtone-icons/v4.31.1...dialtone-icons/v4.31.2) (2024-12-10)

### Bug Fixes

* **Icon:** DLT-2206 fix icon Simultaneous ring ([#579](#579)) ([1435dbd](1435dbd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braddialpad braddialpad braddialpad approved these changes

@francisrupert francisrupert francisrupert approved these changes

@juliodialpad juliodialpad Awaiting requested review from juliodialpad juliodialpad is a code owner

@iropolo iropolo Awaiting requested review from iropolo iropolo is a code owner

@ninamarina ninamarina Awaiting requested review from ninamarina ninamarina is a code owner

Assignees
No one assigned
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fede-dp @francisrupert @braddialpad