Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DLT-1890 vscode-plugin: utility class autocompletion and hover #609

Merged
merged 8 commits into from
Jan 17, 2025

Conversation

juliodialpad
Copy link
Collaborator

[VSCode Plugin] Utility class autocompletion and hover

Obligatory GIF (super important!)

Obligatory GIF

πŸ› οΈ Type Of Change

These types will increment the version number on release:

  • Feature

πŸ“– Jira Ticket

https://dialpad.atlassian.net/browse/DLT-1890

πŸ“– Description

  • Automated the generation of utility classes documentation.
  • Added utility class autocompletion and hover.
  • Fixed issues while autocompleting prop values.
  • Improved performance by checking the part of the code that you're currently at.

πŸ’‘ Context

Utility classes documentation was missing, so created Gulp and PostCSS scripts to automate the extraction and generation of the documentation.

πŸ“ Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

πŸ“· Screenshots / GIFs

  • Auto completion
    2025-01-16 15 33 25

  • Hover
    2025-01-16 15 37 04

@juliodialpad juliodialpad added the no-visual-test Add this tag when the PR does not need visual testing label Jan 16, 2025
@juliodialpad juliodialpad self-assigned this Jan 16, 2025
@francisrupert
Copy link
Contributor

Holy schnikes, this is beautiful.

Copy link
Contributor

@braddialpad braddialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is extremely awesome.

I'm okay with just shipping this and having us test the extension by using it since it's in a beta state and I don't think any of us are really qualified to review the code for a language server.

Let's make sure all the checks pass though.

Copy link

βœ”οΈ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-609/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-609/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-609/

@juliodialpad juliodialpad merged commit d67e226 into staging Jan 17, 2025
6 checks passed
@juliodialpad juliodialpad deleted the utility-class-documentation branch January 17, 2025 18:32
braddialpad pushed a commit that referenced this pull request Jan 21, 2025
# [1.1.0](language-server/v1.0.0...language-server/v1.1.0) (2025-01-19)

### Features

* DLT-1890 vscode-plugin: utility class autocompletion and hover ([#609](#609)) ([d67e226](d67e226))
braddialpad pushed a commit that referenced this pull request Jan 21, 2025
# [1.1.0](vscode-extension/v1.0.0...vscode-extension/v1.1.0) (2025-01-19)

### Features

* DLT-1890 vscode-plugin: utility class autocompletion and hover ([#609](#609)) ([d67e226](d67e226))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-visual-test Add this tag when the PR does not need visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants