Simplify foliage rendering #7366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
extract-foliage
branch
4 times, most recently
from
bc87e0e
to
9d1ed7c
Compare
glebm
force-pushed
the
extract-foliage
branch
4 times, most recently
from
6a5a7d4
to
f60659b
Compare
|
uh, this has a conflict now :o |
|
Rebased |
During `ReencodeDungeonCels`, extracts floor tile foliage into a triangle with the floor frame and a separate 16-px tall `TransparentSquare`. This means that the floor frames are now always triangles and the foliage can be rendered directly without masking. Dungeon graphics sizes: Map | Frames | Foliage frames | Byte size | Before PR | After PR -----|--------|---------------:|-----------:|----------:|----------: Town | 3,803 | 41 | 2,317,832 | 2,242,056 | 2,242,190 L1 | 1,119 | 11 | 738,836 | 721,604 | 721,110 L4 | 1,091 | 6 | 603,140 | 584,500 | 584,242 RG99 binary size reduced by ~4 KiB: 2,426,380 bytes -> 2,421,388 bytes
AJenbo
approved these changes
Aug 28, 2024
|
Nice to have it split the data like this, also good to have the comments to explain what it's doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
ReencodeDungeonCels, extracts floor tile foliage into a triangle with the floor frame and a separate 16-px tallTransparentSquare.This means that the floor frames are now always triangles and the foliage can be rendered directly without masking.
Dungeon graphics sizes:
RG99 binary size reduced by ~4 KiB: 2,426,380 bytes -> 2,421,388 bytes