[move-compiler]Support CRLF as newline for Move files (#90)_46 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/canary |
bors-diem
pushed a commit
that referenced
this pull request
Jan 11, 2023
* [move-compiler] Support CRLF as newline for Move files Fix issue: starcoinorg/starcoin#3130 * feat: validate crlf in source * [move-compiler] Support CRLF as newline for Move files Fix issue: starcoinorg/starcoin#3130 * feat: fix test-ci fail Signed-off-by: sahithiacn <sahithi.kalakonda@accenture.com> Closes: #328
|
☀️ Canary successful |
dhaneshacn
previously approved these changes
Jan 11, 2023
|
/land |
* [move-compiler] Support CRLF as newline for Move files Fix issue: starcoinorg/starcoin#3130 * feat: validate crlf in source * [move-compiler] Support CRLF as newline for Move files Fix issue: starcoinorg/starcoin#3130 * feat: fix test-ci fail Signed-off-by: sahithiacn <sahithi.kalakonda@accenture.com> Closes: diem#328
bors-diem
force-pushed
the
move-compiler-90
branch
from
037e34c
to
d4a268a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support CRLF as newline for Move files
Validate crlf in source
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
move-ir-compiler
language/move-ir-compiler/transactional-tests/tests/parsing/crlf.mvircd language/move-ir-compiler/transactional-tests && cargo testmove-compiler
language/move-compiler/tests/move_check/parser/newline_crlf.movecd language/move-compiler && cargo test