Compile example contracts failed on Windows

[zhutoulala]

I was able to do a local dev build of starcoin on Windows 10, but running into below error when following the tutorial to compile example contracts. Perhaps due to the different line ending?

starcoin% dev compile -o examples examples
�[0m�[1m�[38;5;9merror[E01001]�[0m�[1m: invalid character�[0m
  �[0m�[36m┌─�[0m C:\Users\peter\AppData\Local\Temp\e5f468ac479d3806f90bbd40ac032011\Account.move:1:14
  �[0m�[36m│�[0m
�[0m�[36m1�[0m �[0m�[36m│�[0m address 0x1 {
' found when reading file. Only ASCII printable characters, tabs (\t), and line endings (\n) are permitted.�[0m

�[0m�[1m�[38;5;9merror[E01001]�[0m�[1m: invalid character�[0m
  �[0m�[36m┌─�[0m C:\Users\peter\AppData\Local\Temp\e5f468ac479d3806f90bbd40ac032011\AccountScripts.move:1:14
  �[0m�[36m│�[0m
�[0m�[36m1�[0m �[0m�[36m│�[0m address 0x1 {
' found when reading file. Only ASCII printable characters, tabs (\t), and line endings (\n) are permitted.�[0m

�[0m�[1m�[38;5;9merror[E01001]�[0m�[1m: invalid character�[0m
  �[0m�[36m┌─�[0m C:\Users\peter\AppData\Local\Temp\e5f468ac479d3806f90bbd40ac032011\Authenticator.move:1:1
  �[0m�[36m│�[0m
�[0m�[36m1�[0m �[0m�[36m│�[0m
' found when reading file. Only ASCII printable characters, tabs (\t), and line endings (\n) are permitted.�[0m
...

[jolestar]

Maybe the windows file encode problem, @welbon did you solve the same problem?

[jolestar]

We need to support Move windows develop environment. #3131

[zhutoulala]

The problem is solved by using dos2unix to convert all move files under stdlib folder and example folder. I guess the compiler could add such conversation when reading move files on Windows.

[zhutoulala]

Just created a small PR #3135 for this issue. Fairly new to Rust, kindly let me know if anything needs to be changed

[yubing744]

@jolestar Can help sync the latest code from https://github.com/move-language/move to https://github.com/starcoinorg/move

[jolestar]

@jolestar Can help sync the latest code from https://github.com/move-language/move to https://github.com/starcoinorg/move

@yubing744 I release a alpha version https://github.com/starcoinorg/starcoin/releases/tag/v1.11.8-alpha

[yubing744]

I tested v1.11.8-alpha, found new error:

[yubing744]

The bad case is \t\r\n

[jolestar]

The bad case is \t\r\n

Does we just need to fix the examples?

[yubing744]

The bad case is \t\r\n

Does we just need to fix the examples?

No, I submited a new PR to handle this.

[yubing744]

@jolestar The PR has been merged, can help sync the latest code from https://github.com/move-language/move to https://github.com/starcoinorg/move again.

[jolestar]

@jolestar The PR has been merged, can help sync the latest code from https://github.com/move-language/move to https://github.com/starcoinorg/move again.

release a new alpha version https://github.com/starcoinorg/starcoin/releases/tag/v1.11.9-alpha

[yubing744]

@jolestar The PR has been merged, can help sync the latest code from https://github.com/move-language/move to https://github.com/starcoinorg/move again.

release a new alpha version https://github.com/starcoinorg/starcoin/releases/tag/v1.11.9-alpha

I tested v1.11.9-alpha and the move file is now compatible with both LF and CRLF line breaks, but there are two other issues:

1. There is no environment variable HOME by default on the Windows platform, and executing mpm package build will prompt an error that the HOME environment variable cannot be found.
   

2. Executing the integration test on the Windows platform will cause the verification failure due to the newline of the exp file being replaced by CRLF
   

I have raised two issues:
#3400
#3401

[jolestar]

resolved