fix for issue#3130 - Compile example contracts failed on Windows

[zhutoulala]

add check and conversion from Windows style line ending (CRLF) to Unix stype (LF) for Move contracts

[jolestar]

Thanks for your contribution.

[codecov]

Codecov Report

Merging #3135 (d1e4125) into master (51fc701) will increase coverage by 0.09%.
The diff coverage is 21.43%.

@@            Coverage Diff             @@
##           master    #3135      +/-   ##
==========================================
+ Coverage   32.15%   32.23%   +0.09%     
==========================================
  Files         503      503              
  Lines       46298    46311      +13     
  Branches    21235    21245      +10     
==========================================
+ Hits        14882    14926      +44     
- Misses      17397    17453      +56     
+ Partials    14019    13932      -87     

Flag	Coverage Δ
unittests	32.23% <21.43%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
vm/compiler/src/lib.rs	39.64% <21.43%> (-1.17%)	⬇️
vm/types/src/language_storage_ext.rs	50.00% <0.00%> (-50.00%)	⬇️
...m/types/src/account_config/events/config_change.rs	66.67% <0.00%> (-33.33%)	⬇️
network/src/worker.rs	30.65% <0.00%> (-19.35%)	⬇️
cmd/miner_client/src/solver.rs	16.67% <0.00%> (-16.66%)	⬇️
vm/types/src/on_chain_config/vm_config.rs	35.00% <0.00%> (-11.66%)	⬇️
...ccount_config/resources/module_upgrade_strategy.rs	34.29% <0.00%> (-8.57%)	⬇️
node/src/network_service_factory.rs	20.84% <0.00%> (-8.33%)	⬇️
abi/decoder/src/lib.rs	1.58% <0.00%> (-7.87%)	⬇️
vm/types/src/transaction_metadata.rs	56.72% <0.00%> (-7.46%)	⬇️
... and 101 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51fc701...d1e4125. Read the comment docs.

[jolestar]

please cargo fmt the code @zhutoulala

[zhutoulala]

different topic - the unittest coverage seems pretty low, any existing ticket to bump it up a bit? I can probably help too @jolestar

[jolestar]

different topic - the unittest coverage seems pretty low, any existing ticket to bump it up a bit? I can probably help too @jolestar

Welcome, I write a issue for this #3136

[jolestar]

@lerencao Move compiler has a new version and is this fix still needed?

[nanne007]

CRLF or LF can be solved by set your editor to save newline as window's CRLF or unix's LF.
It's not a problem of Move.

[nanne007]

If you intend to make move support windows' CRLF, you can fire the PR into diem repo to make move parser support CRLF parsing

[zhutoulala]

Thanks for the comments, @lerencao. I agree a better fix could be done on Diem side. Before that happens though, it does impact Windows user experience, especially for developers new to Starcoin. I can close this PR if you guys prefer not to merge it.

[nanne007]

Thanks for the comments, @lerencao. I agree a better fix could be done on Diem side. Before that happens though, it does impact Windows user experience, especially for developers new to Starcoin. I can close this PR if you guys prefer not to merge it.

The preferred way is:

CRLF or LF can be solved by set your editor to save newline as window's CRLF or unix's LF.

[nanne007]

you can just replace "\r\n" with "\n", '\r' alone is still allowed I think.

[jolestar]

@zhutoulala Can you help to resolve this and rebase this pr?

[zhutoulala]

Hello. \r is usually used with \n in most cases. It alone is still allowed, it means to return to the beginning of the current line though, so I doubt if anyone wants to do that in move. I can update this PR with a quick .replace("\r\n", "\n") but it could be a bit slower. Let me know if that's what you want.

[zhutoulala]

Unfortunately editor doesn't get a chance to play here, all move files under vm/stdlib/modules and examples would have the Windows line ending once git clone on Windows using default settings

[jolestar]

Unfortunately editor doesn't get a chance to play here, all move files under vm/stdlib/modules and examples would have the Windows line ending once git clone on Windows using default settings

@lerencao I try on windows and ensure this.