Spotless Gradle Plugin fails Gradle 8.1 with configuration cache enabled #1644

BraisGabin · 2023-03-29T11:48:24Z

Spotless Gradle Plugin 6.17.0 (it also happens with 6.11.0) makes the configuration cache fail on Gradle 8.1-rc-1. This happens just to have the plugin applied. No need to execute any spotless' task.

On macOS I get 4 errors:

> Starting an external process 'bash --login -c which git' during configuration time is unsupported.
> Starting an external process 'xcode-select -p' during configuration time is unsupported.
> Starting an external process '/usr/bin/git --version' during configuration time is unsupported.
> Starting an external process '/usr/bin/git config --system --show-origin --list -z' during configuration time is unsupported.

On Linux I get 2 errors:

> Starting an external process '/usr/bin/git --version' during configuration time is unsupported.
> Starting an external process '/usr/bin/git config --system --show-origin --list -z' during configuration time is unsupported.

The message error also points to this documentation: https://docs.gradle.org/8.1-rc-1/userguide/configuration_cache.html#config_cache:requirements:external_processes

Here you have the 4 stack traces of those errors (from macOS):

org.gradle.api.InvalidUserCodeException: Starting an external process '/usr/bin/git --version' during configuration time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
	at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
	at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1383)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1345)
	at org.eclipse.jgit.util.FS.discoverGitSystemConfig(FS.java:1534)
	at org.eclipse.jgit.util.FS.getGitSystemConfig(FS.java:1631)
	at org.eclipse.jgit.util.SystemReader$Default.openSystemConfig(SystemReader.java:106)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RuntimeInit.<init>(GitAttributesLineEndings.java:160)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:93)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:80)
	at com.diffplug.spotless.LazyForwardingEquality.state(LazyForwardingEquality.java:56)
	at com.diffplug.spotless.LazyForwardingEquality.unlazy(LazyForwardingEquality.java:118)
	at com.diffplug.gradle.spotless.JvmLocalCache$LiveCacheKeyImpl.set(JvmLocalCache.java:60)
	at com.diffplug.gradle.spotless.SpotlessTask.setLineEndingsPolicy(SpotlessTask.java:75)
	at com.diffplug.gradle.spotless.SpotlessTaskImpl_Decorated.setLineEndingsPolicy(Unknown Source)
	at com.diffplug.gradle.spotless.FormatExtension.setupTask(FormatExtension.java:825)
	at com.diffplug.gradle.spotless.KotlinExtension.setupTask(KotlinExtension.java:246)
	at com.diffplug.gradle.spotless.SpotlessExtensionImpl.lambda$createFormatTasks$6(SpotlessExtensionImpl.java:70)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
        ...

org.gradle.api.InvalidUserCodeException: Starting an external process '/usr/bin/git config --system --show-origin --list -z' during configuration time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
	at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
	at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1383)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1345)
	at org.eclipse.jgit.util.FS.discoverGitSystemConfig(FS.java:1573)
	at org.eclipse.jgit.util.FS.getGitSystemConfig(FS.java:1631)
	at org.eclipse.jgit.util.SystemReader$Default.openSystemConfig(SystemReader.java:106)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RuntimeInit.<init>(GitAttributesLineEndings.java:160)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:93)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:80)
	at com.diffplug.spotless.LazyForwardingEquality.state(LazyForwardingEquality.java:56)
	at com.diffplug.spotless.LazyForwardingEquality.unlazy(LazyForwardingEquality.java:118)
	at com.diffplug.gradle.spotless.JvmLocalCache$LiveCacheKeyImpl.set(JvmLocalCache.java:60)
	at com.diffplug.gradle.spotless.SpotlessTask.setLineEndingsPolicy(SpotlessTask.java:75)
	at com.diffplug.gradle.spotless.SpotlessTaskImpl_Decorated.setLineEndingsPolicy(Unknown Source)
	at com.diffplug.gradle.spotless.FormatExtension.setupTask(FormatExtension.java:825)
	at com.diffplug.gradle.spotless.KotlinExtension.setupTask(KotlinExtension.java:246)
	at com.diffplug.gradle.spotless.SpotlessExtensionImpl.lambda$createFormatTasks$6(SpotlessExtensionImpl.java:70)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
        ...

org.gradle.api.InvalidUserCodeException: Starting an external process 'bash --login -c which git' during configuration time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
	at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
	at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1383)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1345)
	at org.eclipse.jgit.util.FS_POSIX.discoverGitExe(FS_POSIX.java:150)
	at org.eclipse.jgit.util.FS.discoverGitSystemConfig(FS.java:1526)
	at org.eclipse.jgit.util.FS.getGitSystemConfig(FS.java:1631)
	at org.eclipse.jgit.util.SystemReader$Default.openSystemConfig(SystemReader.java:106)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RuntimeInit.<init>(GitAttributesLineEndings.java:160)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:93)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:80)
	at com.diffplug.spotless.LazyForwardingEquality.state(LazyForwardingEquality.java:56)
	at com.diffplug.spotless.LazyForwardingEquality.unlazy(LazyForwardingEquality.java:118)
	at com.diffplug.gradle.spotless.JvmLocalCache$LiveCacheKeyImpl.set(JvmLocalCache.java:60)
	at com.diffplug.gradle.spotless.SpotlessTask.setLineEndingsPolicy(SpotlessTask.java:75)
	at com.diffplug.gradle.spotless.SpotlessTaskImpl_Decorated.setLineEndingsPolicy(Unknown Source)
	at com.diffplug.gradle.spotless.FormatExtension.setupTask(FormatExtension.java:825)
	at com.diffplug.gradle.spotless.KotlinExtension.setupTask(KotlinExtension.java:246)
	at com.diffplug.gradle.spotless.SpotlessExtensionImpl.lambda$createFormatTasks$6(SpotlessExtensionImpl.java:70)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
        ...

org.gradle.api.InvalidUserCodeException: Starting an external process 'xcode-select -p' during configuration time is unsupported.
	at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)
	at org.gradle.configurationcache.InstrumentedInputAccessListener.externalProcessStarted(InstrumentedInputAccessListener.kt:110)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:501)
	at org.gradle.internal.classpath.Instrumented.externalProcessStarted(Instrumented.java:509)
	at org.gradle.internal.classpath.Instrumented.start(Instrumented.java:363)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1383)
	at org.eclipse.jgit.util.FS.readPipe(FS.java:1345)
	at org.eclipse.jgit.util.FS_POSIX.discoverGitExe(FS_POSIX.java:169)
	at org.eclipse.jgit.util.FS.discoverGitSystemConfig(FS.java:1526)
	at org.eclipse.jgit.util.FS.getGitSystemConfig(FS.java:1631)
	at org.eclipse.jgit.util.SystemReader$Default.openSystemConfig(SystemReader.java:106)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RuntimeInit.<init>(GitAttributesLineEndings.java:160)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:93)
	at com.diffplug.spotless.extra.GitAttributesLineEndings$RelocatablePolicy.calculateState(GitAttributesLineEndings.java:80)
	at com.diffplug.spotless.LazyForwardingEquality.state(LazyForwardingEquality.java:56)
	at com.diffplug.spotless.LazyForwardingEquality.unlazy(LazyForwardingEquality.java:118)
	at com.diffplug.gradle.spotless.JvmLocalCache$LiveCacheKeyImpl.set(JvmLocalCache.java:60)
	at com.diffplug.gradle.spotless.SpotlessTask.setLineEndingsPolicy(SpotlessTask.java:75)
	at com.diffplug.gradle.spotless.SpotlessTaskImpl_Decorated.setLineEndingsPolicy(Unknown Source)
	at com.diffplug.gradle.spotless.FormatExtension.setupTask(FormatExtension.java:825)
	at com.diffplug.gradle.spotless.KotlinExtension.setupTask(KotlinExtension.java:246)
	at com.diffplug.gradle.spotless.SpotlessExtensionImpl.lambda$createFormatTasks$6(SpotlessExtensionImpl.java:70)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
	at org.gradle.api.internal.DefaultMutationGuard$1.execute(DefaultMutationGuard.java:45)
        ...

I could create a reproducer if needed.

The text was updated successfully, but these errors were encountered:

nedtwigg · 2023-04-03T23:42:12Z

Thanks for the error report! This is probably going to hit us in a few places

GitAttributesLineEndings (the stacktraces you provided)
- we can fix this bug at the same time as GIT_ATTRIBUTES massive slowdown in Spotless 6.6.0+ #1527
GitRatchet
- this will probably require a different fix, but similar to the above
Running external formatters
- https://github.com/diffplug/spotless/blob/main/lib/src/main/java/com/diffplug/spotless/ProcessRunner.java
- we'll have to modify the code above to use one of the workarounds below
- https://docs.gradle.org/8.1-rc-1/userguide/configuration_cache.html#config_cache:requirements:external_processes

This change in 8.1 seems likely to wreak havoc in the plugin ecosystem, maybe some mitigations will become available...

BraisGabin · 2023-04-24T14:21:38Z

There is a workaround for this issue:

spotless {
    // https://github.com/diffplug/spotless/issues/1644
    lineEndings = LineEnding.PLATFORM_NATIVE // or any other except GIT_ATTRIBUTES
}

…/spotless#1644 (comment) Co-authored-by: Marius Eriksen <marius.eriksen@nav.no> Co-authored-by: Mona Kjeldsrud <mona.kjeldsrud@nav.no>

diffplug/spotless#1644

nedtwigg · 2023-09-01T13:57:15Z

Released in plugin-gradle 6.21.0

// using idea found at // <diffplug/spotless#1527 (comment)>.

illarionov added a commit to illarionov/Pixnews that referenced this issue Apr 2, 2023

Workaround diffplug/spotless#1644

44710bb

nedtwigg mentioned this issue Apr 3, 2023

Support Rome as a formatter for JavaScript / TypeScript #1651

Closed

nedtwigg added the bug label Apr 3, 2023

liblit added this to Use Gradle configuration cache Apr 20, 2023

github-project-automation bot moved this to Todo in Use Gradle configuration cache Apr 20, 2023

liblit mentioned this issue Apr 22, 2023

Work around Spotless conflict with Gradle configuration cache wala/WALA#1272

Merged

KENNYSOFT mentioned this issue Apr 23, 2023

Configuration cache problems in Gradle 8.1 n0mer/gradle-git-properties#225

Open

marcphilipp added a commit to junit-team/testng-engine that referenced this issue Apr 28, 2023

Work around diffplug/spotless#1644

1f8f24d

nedtwigg mentioned this issue Apr 29, 2023

spotless gradle plugin leaks memory (massively) #1194

Closed

ashdavies mentioned this issue Jun 6, 2023

chore(deps): update dependency gradle to v8.1.1 (main) ashdavies/playground.ashdavies.dev#288

Merged

1 task

torresmi added a commit to torresmi/reductions-android that referenced this issue Jun 10, 2023

Downgrade Gradle for Spotless bug

1331dd8

diffplug/spotless#1644

chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 20, 2023

Workaround Spotless config cache

a9b230a

diffplug/spotless#1644

chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 20, 2023

Workaround Spotless config cache

8e2c337

diffplug/spotless#1644

chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 21, 2023

Workaround Spotless config cache

12eafc6

diffplug/spotless#1644

chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 22, 2023

Workaround Spotless config cache

9dd8ddc

diffplug/spotless#1644

chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 25, 2023

Workaround Spotless config cache

e69b777

diffplug/spotless#1644

chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 26, 2023

Workaround Spotless config cache

62e1811

diffplug/spotless#1644

chrisbanes added a commit to chrisbanes/tivi that referenced this issue Jul 26, 2023

Workaround Spotless config cache

4be1080

diffplug/spotless#1644

tylerbertrand mentioned this issue Aug 4, 2023

Fix Config Cache External Process Issue #1777

Merged

nedtwigg closed this as completed in b99ec3d Aug 7, 2023

github-project-automation bot moved this from Todo to Done in Use Gradle configuration cache Aug 7, 2023

geiralund added a commit to navikt/dagpenger-events that referenced this issue Aug 17, 2023

Workaround for <diffplug/spotless#1644>

be12a5e

geiralund added a commit to navikt/dagpenger-events that referenced this issue Aug 17, 2023

Workaround for <diffplug/spotless#1644>

510a097

geiralund added a commit to navikt/dagpenger-streams that referenced this issue Aug 18, 2023

Workaround for diffplug/spotless#1644

592df7e

geiralund added a commit to navikt/dagpenger-joark-mottak that referenced this issue Sep 12, 2023

// Workaround for <diffplug/spotless#1644>

4c124df

// using idea found at // <diffplug/spotless#1527 (comment)>.

dturner mentioned this issue Apr 8, 2024

Update Spotless and ktlint - Code style rule changes android/architecture-samples#1002

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spotless Gradle Plugin fails Gradle 8.1 with configuration cache enabled #1644

Spotless Gradle Plugin fails Gradle 8.1 with configuration cache enabled #1644

BraisGabin commented Mar 29, 2023

nedtwigg commented Apr 3, 2023

BraisGabin commented Apr 24, 2023

nedtwigg commented Sep 1, 2023

Spotless Gradle Plugin fails Gradle 8.1 with configuration cache enabled #1644

Spotless Gradle Plugin fails Gradle 8.1 with configuration cache enabled #1644

Comments

BraisGabin commented Mar 29, 2023

nedtwigg commented Apr 3, 2023

BraisGabin commented Apr 24, 2023

nedtwigg commented Sep 1, 2023