Fix Config Cache External Process Issue #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the external git processes are launched at execution time and not during configuration
|
Amazing, thanks! This is a fix for #1764, correct? |
|
Needs a |
Goooler
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a configuration cache failure when applying Spotless Gradle Plugin.
The failure is caused by executing external processes during configuration time, which the configuration cache does not support. Specifically, the external processes are launched to determine the line ending policy when
LineEnding.GIT_ATTRIBUTESis used.This PR uses
Providers to supply the line ending policy, which because they are lazily evaluated, move the external processes involved in creating the line ending policy from configuration to execution time.Using spotless-plugin-gradle:6.21.0-SNAPSHOT published to mavenLocal containing these changes results in a successful configuration cache write.