google-java-format Windows bug workaround now only runs for affected version (1.1).

[jbduncan]

No description provided.

[jbduncan]

Related to #65.

[nedtwigg]

LGTM!

[nedtwigg]

Oh, except I didn't realize that it didn't bump the default version to 1.2. I think it should definitely use 1.2.

[jbduncan]

Oh, except I didn't realize that it didn't bump the default version to 1.2. I think it should definitely use 1.2.

Okey dokey! I've pushed a new commit fixing this at 1250f5a.

[jbduncan]

Notes for self:

1. Update RemoveUnusedImports.java to use google-java-format 1.2.
2. Find a way to test that fixWindowsBug is only run if google-java-format version is 1.1. @nedtwigg Do you have any thoughts on how I could do this?

[nedtwigg]

1. I think that's already done:

   spotless/lib/src/main/java/com/diffplug/spotless/java/RemoveUnusedImportsStep.java

   Line 30 in 2500422

   () -> new GoogleJavaFormatStep.State(NAME, GoogleJavaFormatStep.defaultVersion(), provisioner),

2. Perfect world would have a test, I don't see a good way to do it. I think we should merge, and then test 3.1.0-SNAPSHOT on junit. If removeUnusedImports now works for them, that's good enough for me. Feel free to merge at your convenience / satisfaction :)

[jbduncan]

1. Oh yes, you're right! Thanks for pointing that out for me.
2. Okay, in that case I agree on merging this as-is. Doing that now. :)

[jbduncan]

@nedtwigg, how do you prefer PRs to be merged in for Spotless:

1. Merge commit,
2. Squash and merge commit,
3. Rebase and commit on top of master?

[nedtwigg]

Merge commit. Easy to revert if there's a problem, keeps history intact.

[jbduncan]

Done. :)

[jbduncan]

Hi @nedtwigg, I've just tested the latest spotless-plugin-gradle snapshot against JUnit 5 snapshot with the removeUnusedImports() option enabled.

AFAICT, it works beautifully! So we should consider releasing 3.1 soon. :)