Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

500 error when handling already exsisting child entites #1088

Closed
Fargekritt opened this issue Sep 5, 2024 · 0 comments
Closed

500 error when handling already exsisting child entites #1088

Fargekritt opened this issue Sep 5, 2024 · 0 comments
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@Fargekritt
Copy link
Contributor

Reproduction

  1. Create any dialog containing transmission and or activities
  2. Get the dialog using serviceOwner API
  3. Attempt to update the dialog using the output from the get

Expected behavior

Error explaining that the transmission and or activities already exsists

Actual behavior

500 error
@Fargekritt Fargekritt added the bug Something isn't working label Sep 5, 2024
@Fargekritt Fargekritt moved this to New issues in Dialogporten / Arbeidsflate Sep 5, 2024
@oskogstad oskogstad self-assigned this Sep 7, 2024
@oskogstad oskogstad moved this from Backlog to Code Review og PR in Dialogporten / Arbeidsflate Sep 7, 2024
@oskogstad oskogstad mentioned this issue Sep 7, 2024
Merged
4 tasks
oskogstad added a commit that referenced this issue Sep 9, 2024
@oskogstad
fix(webapi): Return 422 when existing transmission IDs are used in di…
7a8a933 
…alog update (#1094)

<!--- Provide a general summary of your changes in the Title above -->

## Description

Regression(?), or missed bug from when transmissions where introduced.
* Added missing return when finding existing IDs
* Adjusted the log message for existing activities to use the same
extension method as transmissions
* Added tests for both existing activities and existing transmissions 

## Related Issue(s)

- #1088 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)
@elsand elsand closed this as completed Sep 12, 2024
@github-project-automation github-project-automation bot moved this from Testing / Design QA to Done in Dialogporten / Arbeidsflate Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
Dialogporten / Arbeidsflate
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elsand @oskogstad @Fargekritt