Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapi): Return 422 when existing transmission IDs are used in dialog update #1094

Conversation

oskogstad
Copy link
Collaborator

Description

Regression(?), or missed bug from when transmissions where introduced.

  • Added missing return when finding existing IDs
  • Adjusted the log message for existing activities to use the same extension method as transmissions
  • Added tests for both existing activities and existing transmissions

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@oskogstad oskogstad requested a review from a team as a code owner September 7, 2024 21:54
Copy link

sonarqubecloud bot commented Sep 8, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@oskogstad oskogstad merged commit 7a8a933 into main Sep 9, 2024
20 checks passed
@oskogstad oskogstad deleted the fix/internal-server-error-when-including-existing-transmissions-in-update branch September 9, 2024 08:15
arealmaas pushed a commit that referenced this pull request Sep 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.17.0](v1.16.0...v1.17.0)
(2024-09-10)


### Features

* Add SubjectResource entity and db migration
([#1048](#1048))
([d04d764](d04d764))
* **graphQL:** Add subscription for dialog details
([#1072](#1072))
([8214acb](8214acb))
* Implement scalable dialog search authorization
([#875](#875))
([aa8f84d](aa8f84d))
* revise dialog status
([#1099](#1099))
([0029f46](0029f46))


### Bug Fixes

* ensure correct appsettings is used
([#1086](#1086))
([d43f6d7](d43f6d7))
* ensure jobs are run with correct arguments and parameters
([#1085](#1085))
([e21de56](e21de56))
* **webapi:** Return 422 when existing transmission IDs are used in
dialog update
([#1094](#1094))
([7a8a933](7a8a933))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants