Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure jobs are run with correct arguments and parameters #1085

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Sep 5, 2024

Description

Apparently, the command property in Bicep for Azure Container Apps overrides the ENTRYPOINT property in the Dockerfile 🤷 Changing to using arguments instead. Tested with manual update of the container app job.

https://azureossd.github.io/2024/01/17/Container-Apps-Using-the-command-override-option/

Other things:

  • Added application insights connection string
  • Added ASPNETCORE_ENVIRONMENT in order to use correct appconfig-file

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@arealmaas arealmaas requested review from a team as code owners September 5, 2024 10:39
oskogstad
oskogstad previously approved these changes Sep 5, 2024
@arealmaas arealmaas changed the title ci: ensure jobs are run with correct arguments fix: ensure jobs are run with correct arguments and parameters Sep 5, 2024
Copy link

sonarqubecloud bot commented Sep 5, 2024

@arealmaas arealmaas merged commit e21de56 into main Sep 5, 2024
22 checks passed
@arealmaas arealmaas deleted the ci/fix-jobs branch September 5, 2024 11:46
arealmaas pushed a commit that referenced this pull request Sep 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.17.0](v1.16.0...v1.17.0)
(2024-09-10)


### Features

* Add SubjectResource entity and db migration
([#1048](#1048))
([d04d764](d04d764))
* **graphQL:** Add subscription for dialog details
([#1072](#1072))
([8214acb](8214acb))
* Implement scalable dialog search authorization
([#875](#875))
([aa8f84d](aa8f84d))
* revise dialog status
([#1099](#1099))
([0029f46](0029f46))


### Bug Fixes

* ensure correct appsettings is used
([#1086](#1086))
([d43f6d7](d43f6d7))
* ensure jobs are run with correct arguments and parameters
([#1085](#1085))
([e21de56](e21de56))
* **webapi:** Return 422 when existing transmission IDs are used in
dialog update
([#1094](#1094))
([7a8a933](7a8a933))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants