Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement actor entity #912

Merged
merged 4 commits into from
Jul 22, 2024
Merged

feat: Implement actor entity #912

merged 4 commits into from
Jul 22, 2024

Conversation

elsand
Copy link
Member

@elsand elsand commented Jul 21, 2024 •
edited
Loading

This is a rewrite of #901, taking into account the clarified requirements in #851

Description

  • Introduces the DialogActor entity, with DB migrations (breaking)
  • Replaces the strings for "performedBy" and "seenBy" with instances of DialogActor. This should also be used for "sender" when "transmission" is introduced.
  • Adds DTOs, mappings and validations for all enduser and service owner endpoints
  • Hash service replaced with static helper, used directly in mappers
  • Refactored PersonNameRegistry to PartyNameRegistry
  • Implement actor name lookup if actor id is supplied
  • Replaced "via serviceowner" with a simple boolean value (should be used in Utvide tjensteier-detalj-API med parameter for sluttbrukers fnr #386)
  • Updated seen tests (pid masking)
  • Added activity log tests (pid masking)

Missing

  • Updated e2e tests

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@elsand elsand mentioned this pull request Jul 21, 2024
Closed
4 tasks
@elsand elsand marked this pull request as ready for review July 22, 2024 06:07
@elsand elsand requested a review from a team as a code owner July 22, 2024 06:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@oskogstad oskogstad merged commit a635fcb into main Jul 22, 2024
17 of 18 checks passed
@oskogstad oskogstad deleted the feature/actor branch July 22, 2024 14:44
@dialogporten-bot dialogporten-bot mentioned this pull request Jul 22, 2024
Merged
arealmaas pushed a commit that referenced this pull request Jul 30, 2024
@dialogporten-bot
chore(main): release 1.9.0 (#849)
1ab6380 
🤖 I have created a release *beep* *boop*
---


##
[1.9.0](v1.8.1...v1.9.0)
(2024-07-30)


### Features

* **breaking:** Move front channel embeds to content
([#862](#862))
([c9b50e9](c9b50e9))
* **breaking:** Remove DialogElements, add Attachments
([#867](#867))
([dbe296a](dbe296a))
* **breaking:** Remove PUT/DELETE endpoints for DialogElements
([#844](#844))
([51eb898](51eb898))
* **breaking:** Rename CultureCode to LanguageCode
([#871](#871))
([96d50fc](96d50fc))
* **breaking:** Renaming dialog activity types
([#919](#919))
([af262b1](af262b1))
* Change content array to object with properties for each content type
([#905](#905))
([d549f19](d549f19))
* Implement actor entity
([#912](#912))
([a635fcb](a635fcb))
* Introduce Transmissions
([#932](#932))
([3ca495f](3ca495f))
* Rename DialogStatus enum values
([#915](#915))
([5aea32b](5aea32b))
* **WebAPI:** Add Transmission endpoints
([#943](#943))
([d608ade](d608ade))


### Bug Fixes

* Allow new activities to reference old activities
([#935](#935))
([bbc443e](bbc443e))
* **auth:** Malformed JWTs no longer results in InternalServerError
([#870](#870))
([5f2f386](5f2f386))
* **slackNotifier:** Add missing deployment of Slack notifier function
in staging environment
([#861](#861))
([59091f7](59091f7))
* Update e2e tests for actor model
([#918](#918))
([ec1fcb1](ec1fcb1))
* **WebAPI:** Allow purging of softly deleted dialogs
([#940](#940))
([c527c9f](c527c9f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskogstad oskogstad oskogstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elsand @oskogstad