Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): add redis resource #518

Merged
merged 12 commits into from
Mar 6, 2024
Merged

feat(azure): add redis resource #518

merged 12 commits into from
Mar 6, 2024

Conversation

arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Mar 5, 2024

Related to #275

  • Added Redis resource to infrastructure
  • Added host name to the key vault and app configuration to make it accessible to the container app.
  • Using managed identity to connect the web apis to Redis

Doesn't seem like managed identity is possible for apps that read/write to the redis instance. We could use a pre-defined role, but that would only enable control plane level permissions.. ¯_(ツ)_/¯

oskogstad
oskogstad previously approved these changes Mar 6, 2024
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@arealmaas arealmaas merged commit 1b2c013 into main Mar 6, 2024
7 of 8 checks passed
@arealmaas arealmaas deleted the feat/add-redis branch March 6, 2024 08:58
oskogstad pushed a commit that referenced this pull request Mar 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](v1.0.4...v1.1.0)
(2024-03-13)


### Features

* Add name lookups
([#532](#532))
([db9cadc](db9cadc))
* **azure:** add redis resource
([#518](#518))
([1b2c013](1b2c013))
* use redis in web api
([#527](#527))
([eabd708](eabd708))


### Bug Fixes

* Allow for 2 seconds clock skew in token validation
([#536](#536))
([a0147b8](a0147b8))
* **azure:** rename connection string key for redis
([#533](#533))
([db36213](db36213))
* **azure:** revert to using connection string for IDistributedCache
Redis ([#526](#526))
([d19350d](d19350d))
* **azure:** use built-in policy for redis
([#521](#521))
([2a8fa76](2a8fa76))
* **azure:** use secret uri instead of host name in app config
([#522](#522))
([7cafd77](7cafd77))
* **azure:** use SSL port for redis in connection string
([#546](#546))
([548bc47](548bc47))
* Change IfMatchDialogRevision to Revision in DTO
([#535](#535))
([3a065d3](3a065d3))
* purge should accept any content-type and no body
([#540](#540))
([736fb59](736fb59))
* remove prefix for redis connection string
([#541](#541))
([ceb204c](ceb204c))
* Update Altinn Authorization integration
([#457](#457))
([#469](#469))
([d0d846d](d0d846d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants