fix: purge should accept any content-type and no body #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This validates the GUID input on purge commands so that we get a 400 error, instead of 500, when posting bad GUIDs. (The error will always say "DialogId cannot be 00000...", and not "invalid JSON" .. but better than nothing)
elsand
previously approved these changes
Mar 13, 2024
knuhau
commented
Mar 13, 2024
...n.Application/Features/V1/ServiceOwner/Dialogs/Commands/Purge/PurgeDialogCommandValidator.cs
Outdated
Show resolved
Hide resolved
…Owner/Dialogs/Commands/Purge/PurgeDialogCommandValidator.cs
elsand
approved these changes
Mar 13, 2024
|
oskogstad
pushed a commit
that referenced
this pull request
Mar 13, 2024
🤖 I have created a release *beep* *boop* --- ## [1.1.0](v1.0.4...v1.1.0) (2024-03-13) ### Features * Add name lookups ([#532](#532)) ([db9cadc](db9cadc)) * **azure:** add redis resource ([#518](#518)) ([1b2c013](1b2c013)) * use redis in web api ([#527](#527)) ([eabd708](eabd708)) ### Bug Fixes * Allow for 2 seconds clock skew in token validation ([#536](#536)) ([a0147b8](a0147b8)) * **azure:** rename connection string key for redis ([#533](#533)) ([db36213](db36213)) * **azure:** revert to using connection string for IDistributedCache Redis ([#526](#526)) ([d19350d](d19350d)) * **azure:** use built-in policy for redis ([#521](#521)) ([2a8fa76](2a8fa76)) * **azure:** use secret uri instead of host name in app config ([#522](#522)) ([7cafd77](7cafd77)) * **azure:** use SSL port for redis in connection string ([#546](#546)) ([548bc47](548bc47)) * Change IfMatchDialogRevision to Revision in DTO ([#535](#535)) ([3a065d3](3a065d3)) * purge should accept any content-type and no body ([#540](#540)) ([736fb59](736fb59)) * remove prefix for redis connection string ([#541](#541)) ([ceb204c](ceb204c)) * Update Altinn Authorization integration ([#457](#457)) ([#469](#469)) ([d0d846d](d0d846d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #538