Scaffold autoscaler openapi spec #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenVarela
force-pushed
the
droplet-autoscale-pool-openapi-spec
branch
6 times, most recently
from
50148e8 to
5daa5ea
Compare
hazel-nut
reviewed
Nov 26, 2024
specification/resources/autoscale_pools/autoscale_pool_create.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/autoscale_pool_delete.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/autoscale_pool_delete_dangerous.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/autoscale_pool_list.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/models/member_current_utilization.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/models/member_current_utilization.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/responses/existing_autoscale_pool.yml
Outdated
Show resolved
Hide resolved
StephenVarela
force-pushed
the
droplet-autoscale-pool-openapi-spec
branch
from
9d5307e to
9482a2d
Compare
StephenVarela
force-pushed
the
droplet-autoscale-pool-openapi-spec
branch
from
9482a2d to
7d139c6
Compare
hazel-nut
reviewed
Nov 27, 2024
specification/resources/autoscale_pools/autoscale_pool_list_members.yml
Outdated
Show resolved
Hide resolved
|
|
||
| description: | | ||
| To update the configuration of an existing autoscale pool, send a PUT request to | ||
| `/v2/droplets/autoscale/$AUTOSCALE_POOL_ID`. The request should contain a full representation |
There was a problem hiding this comment.
Suggested change
| `/v2/droplets/autoscale/$AUTOSCALE_POOL_ID`. The request should contain a full representation | |
| `/v2/droplets/autoscale/$AUTOSCALE_POOL_ID`. The request will contain a full representation |
There was a problem hiding this comment.
hmm maybe must?
- Trying to indicate to the user that they need to provide the full representation and not just the fields they are trying to change
specification/resources/autoscale_pools/models/autoscale_pool.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/models/autoscale_pool.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/models/autoscale_pool.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/models/autoscale_pool_create.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/models/autoscale_pool_create.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/models/autoscale_pool_dynamic_config.yml
Outdated
Show resolved
Hide resolved
3 tasks
loosla
reviewed
Dec 5, 2024
loosla
reviewed
Dec 5, 2024
specification/resources/autoscale_pools/models/autoscale_pool_droplet_template.yml
Outdated
Show resolved
Hide resolved
loosla
reviewed
Dec 5, 2024
specification/resources/autoscale_pools/models/autoscale_pool_droplet_template.yml
Show resolved
Hide resolved
|
👋 Great work! Just a couple of small comments to address, and then I’ll be ready to approve. |
|
Looks good to me 👍 Thank you for the updates |
loosla
previously approved these changes
Dec 12, 2024
hazel-nut
reviewed
Dec 13, 2024
specification/resources/autoscale_pools/models/autoscale_pool_droplet_template.yml
Outdated
Show resolved
Hide resolved
specification/resources/autoscale_pools/models/autoscale_pool_droplet_template.yml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Droplet Autoscaler Openapi spec