Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add placeholder to avoid empty input fields from jumping #70

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Add placeholder to avoid empty input fields from jumping #70

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9df28e2
Add placeholder to avoid empty input fields from jumping
Jul 27, 2021
d975de5
Add comment to explain placeholder hack
Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions webapp/app/forms/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ def __call__(self, field, **kwargs):
if 'required' not in kwargs and 'required' in getattr(field, 'flags', []):
kwargs['required'] = True
kwargs['class'] = 'form-control'
# Safari has a bug where empty input fields do not align correctly with baseline alignment.
# Thus, we add a placeholder.
kwargs['placeholder'] = ' '

joined_input_fields = Markup()
for idx, input_field_length in enumerate(self.input_field_lengths):
Expand Down