Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder to avoid empty input fields from jumping #70

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

frederike-ramin
Copy link
Member

Short Description

Changes

  • Added an empty placeholder, because then the field is not technically empty and the fields are correctly aligned (solution from the above post)

Feedback

  • Do you see any problems with this?

Safari has a bug that makes the baseline alignment not work as intended on empty input fields in a flexbox with baseline alignment.
Copy link
Member

@nfelger nfelger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent find! The line you added desperately needs a comment though - no one will understand why we add a space as the placeholder.

@frederike-ramin frederike-ramin merged commit 33aeab0 into main Jul 28, 2021
@frederike-ramin frederike-ramin deleted the safari-no-jump-on-empty-input branch July 28, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants