fix: Correct cli argument order

Closes karma-runner#92, karma-runner#94
dignifiedquire · Jan 4, 2016 · e33946d · e33946d
1 parent 7b5e522
commit e33946d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -61,13 +61,17 @@ var PhantomJSBrowser = function (baseBrowserDecorator, config, args, logger) {
 
     fs.writeFileSync(captureFile, captureCode)
 
-    // PhantomJS takes its script file as the first cmd-line argument
-    var flags = [captureFile].concat(providedFlags)
+    // PhantomJS has the following convention for arguments
+    // phantomjs [switchs] [options] [script] [argument [argument [...]]]
+    // with  options being equal to flags
+    var flags = providedFlags
     if (args.debug) {
       flags.push('--remote-debugger-port=9000')
       flags.push('--remote-debugger-autorun=yes')
     }
 
+    flags.push(captureFile)
+
     // and start phantomjs
     this._execCommand(this._getCommand(), flags)
 

diff --git a/karma.conf.js b/karma.conf.js
@@ -43,12 +43,19 @@ module.exports = function (config) {
 
     // start these browsers
     // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
-    browsers: ['PhantomJS'],
+    browsers: ['PhantomJS', 'PhantomJS_flags'],
 
     // Continuous Integration mode
     // if true, Karma captures browsers, runs the tests and exits
     singleRun: true,
 
+    customLaunchers: {
+      'PhantomJS_flags': {
+        base: 'PhantomJS',
+        flags: ['--load-images=false']
+      }
+    },
+
     plugins: [
       require('karma-jasmine'),
       require('./index')