[webpack] Multiselect pages #35413
Merged
[webpack] Multiselect pages #35413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5 page The config change is necessary because this library expects a "jQuery" property to be set on the window. See https://github.com/lou/multi-select/blob/57fb8d3f5d27a0e1058f63921cdb26b4d30da361/js/jquery.multi-select.js#L544
This library was throwing errors relating to functions not being found as expected on the window. Rather than troubleshoot, I'm just killing it. Usages of the multiselect widget don't have that many items, a basic search is fine. quicksearch appears abandoned, no updates in 8 years: https://www.npmjs.com/package/quicksearch
orangejenny
requested review from
a team,
esoergel and
biyeun
as code owners
dimagimon
added
dependencies
millerdev
reviewed
Nov 22, 2024
webpack/webpack.b3.common.js
Outdated
| @@ -14,6 +14,7 @@ module.exports = Object.assign({}, commonDefault, { | |||
| new webpack.ProvidePlugin({ | |||
| '$': 'jquery', | |||
| 'jQuery': 'jquery', // needed for bootstrap 3 to work | |||
| 'window.jQuery': 'jquery', | |||
There was a problem hiding this comment.
Does this mean webpack is making jQuery globally available? Why is it needed? Would it make sense to add a comment here about that?
Is it possibly related to quicksearch, which is removed in a later commit in this PR?
The same applies to webpack/webpack.common.js
There was a problem hiding this comment.
Yes, it does. The two previous lines do something pretty similar by automatically importing jQuery everywhere. It's needed because the multiselect library expects window.jQuery: https://github.com/lou/multi-select/blob/57fb8d3f5d27a0e1058f63921cdb26b4d30da361/js/jquery.multi-select.js#L544
millerdev
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This adds support for multiselect, migrates some pages that depend on it, and removes the
quicksearchdependency from HQ, which wasn't adding enough value to justify maintaining it. See commit messages for detail.https://dimagi.atlassian.net/browse/SAAS-16271
Safety Assurance
Safety story
I've tested the multiselect changes and the migrations locally. The multiselect changes are pretty small, and the migrations are pretty standard (i.e., the pages being migrated aren't dependent on any libraries that aren't used on webpack pages, other than multiselect).
Automated test coverage
Little if any
QA Plan
Not requesting QA
Rollback instructions
Labels & Review