Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webpack] Multiselect pages #35413

Merged
merged 11 commits into from
Nov 22, 2024
Merged

[webpack] Multiselect pages #35413

merged 11 commits into from
Nov 22, 2024
+80 −43

Commits on Nov 21, 2024

  1. Updated webpack config to fix multiselect error, migrate a B3 and a B… 

    …5 page

The config change is necessary because this library expects a "jQuery" property to be set on the window.
See https://github.com/lou/multi-select/blob/57fb8d3f5d27a0e1058f63921cdb26b4d30da361/js/jquery.multi-select.js#L544
    @orangejenny
    orangejenny committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4c73bee View commit details
    Browse the repository at this point in the history

  2. Replaced quicksearch with a simple indexOf search. 

    This library was throwing errors relating to functions not being found as expected on the window. Rather than
troubleshoot, I'm just killing it. Usages of the multiselect widget don't have that many items, a basic search is fine.
quicksearch appears abandoned, no updates in 8 years: https://www.npmjs.com/package/quicksearch
    @orangejenny
    orangejenny committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a880b06 View commit details
    Browse the repository at this point in the history

  3. Removed quicksearch dependency from HQ

    @orangejenny
    orangejenny committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4a72c49 View commit details
    Browse the repository at this point in the history

  4. Migrated reports/js/bootstrap5/edit_scheduled_report

    @orangejenny
    orangejenny committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    43ea49a View commit details
    Browse the repository at this point in the history

  5. Migrated users pages

    @orangejenny
    orangejenny committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ce01cf5 View commit details
    Browse the repository at this point in the history

  6. Migrated linked_domain

    @orangejenny
    orangejenny committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0f9fb22 View commit details
    Browse the repository at this point in the history

  7. "Bootstrap 5 Migration - Rebuilt diffs"

    @orangejenny
    orangejenny committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d93ee6a View commit details
    Browse the repository at this point in the history

  8. Removed unused dependency

    @orangejenny
    orangejenny committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    cf874e1 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Added comment to new config

    @orangejenny
    orangejenny committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    80e642e View commit details
    Browse the repository at this point in the history

  2. Updated search to be case-insensitive

    @orangejenny
    orangejenny committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    69ef32a View commit details
    Browse the repository at this point in the history

  3. Added support for multi-term searches

    @orangejenny
    orangejenny committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    341d4df View commit details
    Browse the repository at this point in the history