feat: make access mode configurable with default option #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to set the pvc as rwx for instance. If no value has been set it will use rwo as default.
|
👍 |
|
Hey @fuse , thanks for this contribution and your patience! You could afterwards also run |
|
I just merged a similar PR #176 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
It should be possible to set the pvc as rwx for instance. If no value has been set it will use rwo as default.
Benefits
Being able to deploy with rwx storage.
Possible drawbacks
Someone could configure it wrong but then he could just remove its custom value.
Applicable issues
Cluster with several worker and the willing to be able to deploy kuma on any, mostly for fault tolerance.
Additional information
Value was already documented as usable in README but is not. I didn’t upgrade version as this minor fix could be part of larger release.
Checklist
Chart.yamlaccording to semver.