Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make access mode configurable with default option #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fuse
Copy link

@fuse fuse commented Dec 19, 2023

Description of the change

It should be possible to set the pvc as rwx for instance. If no value has been set it will use rwo as default.

Benefits

Being able to deploy with rwx storage.

Possible drawbacks

Someone could configure it wrong but then he could just remove its custom value.

Applicable issues

Cluster with several worker and the willing to be able to deploy kuma on any, mostly for fault tolerance.

Additional information

Value was already documented as usable in README but is not. I didn’t upgrade version as this minor fix could be part of larger release.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md

It should be possible to set the pvc as rwx for instance.
If no value has been set it will use rwo as default.
@fuse fuse requested a review from dirsigler as a code owner December 19, 2023 13:59
@lesmyrmidons
Copy link

👍

@dirsigler
Copy link
Owner

Hey @fuse ,

thanks for this contribution and your patience!
Could you please rebase the latest changes from main and also then bump the ChartVersion in your branch here.

You could afterwards also run helm-docs . to update the README.md file with your changes.
Afterwards the PR will probably look fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants