Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make accessMode configurable via values.yaml #176

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

blackbass64
Copy link
Contributor

Description of the change

This PR updates the pvc.yaml to support dynamic input for accessMode from the values.yaml file. Previously, the access mode was hard-coded as ReadWriteOnce. With this change, users can configure the accessMode via values.yaml.

Benefits

  • Increased flexibility in specifying Persistent Volume access modes.
  • Allows users to configure different accessMode options like ReadWriteMany, ReadOnlyMany, etc., depending on their use case.

Possible drawbacks

  • Users who don't specify the accessMode or leave the value as null in values.yaml will default to ReadWriteOnce, which may not fit every scenario.

Applicable issues

  • fixes #

Additional information

No breaking changes are introduced, and this only extends the functionality by making the accessMode configurable.

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md

@dirsigler dirsigler merged commit 0dad79c into dirsigler:main Sep 7, 2024
4 checks passed
@blackbass64 blackbass64 deleted the update-pvc-accessmode branch September 9, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants