Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default select menu values #824

Merged
merged 4 commits into from
Sep 23, 2023
Merged

feat: default select menu values #824

merged 4 commits into from
Sep 23, 2023

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Sep 21, 2023 •
edited by Jiralite
Loading

Please describe the changes this PR makes and why it should be merged:
Supports default select menu values.

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

@jaw0r3k jaw0r3k requested review from a team as code owners September 21, 2023 17:53
@vercel
Copy link

vercel bot commented Sep 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2023 9:45am

@jaw0r3k jaw0r3k force-pushed the default-select-menu-values branch from dd03481 to 40f503d Compare September 21, 2023 19:12
@vladfrangu
Copy link
Member

Do we need to add https://github.com/discord/discord-api-docs/pull/6442/files#diff-160acb4654c611c67c4ee46b2ce5dda2be82212af8d1d00cd0256ef6edda1e95R302 too?

@Renegade334
Copy link
Contributor

Renegade334 commented Sep 22, 2023 •
edited
Loading

Testing confirms that calling the API with default select menu objects that are type-mismatched from the parent select menu component (eg. providing a select menu component with type: ComponentType.UserSelect but giving a default select menu object of type: "channel") returns a DiscordAPIError[50035]: Invalid Form Body.

Accordingly, I think that SelectMenuDefaultValueType needs to be templated such that type is constrained to match its parent select menu component.

@vladfrangu
Copy link
Member

I was referring to the resolved values, but you can also strictly type the default values if you want!

@Renegade334
Copy link
Contributor

Renegade334 commented Sep 23, 2023 •
edited
Loading

@jaw0r3k: I've addressed the APIMessage change in Renegade334@58b65c8778321b690aba056bac2bb4338cf418f4 and the default value type narrowing in Renegade334@33cbceac2e12b88dfb0dddc8cfb1f12bb790a944 - feel free to pull/modify/steal at your leisure

@Jiralite Jiralite merged commit 1290c94 into discordjs:main Sep 23, 2023
5 checks passed
@jaw0r3k jaw0r3k deleted the default-select-menu-values branch September 23, 2023 18:25
@Jiralite Jiralite mentioned this pull request Sep 26, 2023
Merged
@jaw0r3k jaw0r3k mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@Jiralite Jiralite Jiralite approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
topic:payloads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaw0r3k @vladfrangu @Renegade334 @Jiralite @almeidx