feat(SlashCommandBuilder): Add explicit command type when building #10395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
vladfrangu
approved these changes
Jul 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10395 +/- ##
=======================================
Coverage 50.52% 50.53%
=======================================
Files 228 228
Lines 20705 20707 +2
Branches 1252 1252
=======================================
+ Hits 10462 10464 +2
Misses 10199 10199
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Jiralite
approved these changes
Jul 19, 2024
almeidx
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR makes the
SlashCommandBuilderexplicitly specify its type (ApplicationCommandType.ChatInput) when building, by modifying theSharedSlashCommandmixin.One useful scenario for this is when mapping data received from the API (which always contains the type) to a builder's generated data (which currently doesn't contain the type for chat inputs), without relying on a fallback or assuming Discord's default.
I also asked about the issue on the developing-djs channel and a maintainer suggested I should open a PR for it.
Status and versioning classification: