Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SlashCommandBuilder): Add explicit command type when building #10395

Merged
merged 3 commits into from
Jul 21, 2024
Merged

feat(SlashCommandBuilder): Add explicit command type when building #10395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
487e967
feat(SlashCommandBuilder): add explicit command type when building
Amgelo563 Jul 18, 2024
3e56b05
test: add tests
Jiralite Jul 19, 2024
58f4ea7
chore: merge import
almeidx Jul 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/builders/__tests__/interactions/SlashCommands/SlashCommands.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {
ApplicationCommandType,
ApplicationIntegrationType,
ChannelType,
InteractionContextType,
Expand Down Expand Up @@ -133,6 +134,10 @@ describe('Slash Commands', () => {
});

describe('Builder with simple options', () => {
test('GIVEN valid builder THEN returns type included', () => {
expect(getNamedBuilder().toJSON()).includes({ type: ApplicationCommandType.ChatInput });
});

test('GIVEN valid builder with options THEN does not throw error', () => {
expect(() =>
getBuilder()
Expand Down
14 changes: 8 additions & 6 deletions packages/builders/src/interactions/slashCommands/mixins/SharedSlashCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import type {
ApplicationIntegrationType,
InteractionContextType,
LocalizationMap,
Permissions,
RESTPostAPIChatInputApplicationCommandsJSONBody,
import {
ApplicationCommandType,
type ApplicationIntegrationType,
type InteractionContextType,
type LocalizationMap,
type Permissions,
type RESTPostAPIChatInputApplicationCommandsJSONBody,
} from 'discord-api-types/v10';
import type { RestOrArray } from '../../../util/normalizeArray.js';
import { normalizeArray } from '../../../util/normalizeArray.js';
Expand Down Expand Up @@ -149,6 +150,7 @@ export class SharedSlashCommand {

return {
...this,
type: ApplicationCommandType.ChatInput,
options: this.options.map((option) => option.toJSON()),
};
}
Expand Down
Loading