feat(ws): Allow passing in CompressionMethod to ClientOptions to use native node zlib #10411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to not generate a nonce, and PR feedback
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
While that PR was merged it was done in a semver major way and
|
|
Achieving this in a non-breaking way doesn't seem feasible, meaning this pull request is superseded by #10420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
#10316 added support for native zlib support to @discordjs/ws, but there's not currently a way to pass it in to a client(see
discord.js/packages/discord.js/src/client/websocket/WebSocketManager.js
Line 156 in bf6761a
This PR now first checks if you passed in a CompressionMethod, and if not checks if you have
zlib-syncinstalled, if not then no compressionStatus and versioning classification:
Minor