-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fully integrate /ws into mainlib #10420
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
@Qjuh You should also search for "deprecate" in the codebase and remove what is related to WS. I've been working on removing stuff from other parts of the codebase, but it's probably best if stuff like https://github.com/discordjs/discord.js/blob/5eabec14d45ef7bdd7f610e84234eb63e726eacd/packages/discord.js/src/errors/ErrorCodes.js was addressed by this PR. |
For future ref, this should be merged after #10421 - probably cleaner that way. |
53ecdaa
to
e28aee4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10420 +/- ##
=======================================
Coverage 35.48% 35.48%
=======================================
Files 228 228
Lines 14308 14308
Branches 1254 1254
=======================================
Hits 5077 5077
Misses 9187 9187
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0c93210
to
aef22f3
Compare
This needs a rebase |
This reverts commit e28aee4.
aef22f3
to
7ca7247
Compare
Please describe the changes this PR makes and why it should be merged:
BREAKING CHANGE: This removes the compatibility layer of WebSocketManager to integrate
@discordjs/ws
fully into mainlib discord.js without wrapping it.Status and versioning classification: