refactor(*): use async functions #6210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
approved these changes
Jul 29, 2021
|
This needs a rebase. |
vladfrangu
previously requested changes
Jul 29, 2021
NotSugden
force-pushed
the
async-functions
branch
from
63da036 to
e61e3f3
Compare
kyranet
requested changes
Jul 29, 2021
|
This needs a rebase. |
NotSugden
force-pushed
the
async-functions
branch
from
5158e07 to
a40b38b
Compare
|
rebased |
kyranet
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR refactors all functions to be async instead of chaining a
.then(...)- also fixes a couple issues where errors are thrown instead of returning aPromise.reject(...);Status and versioning classification:
untested