-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(WebSocketShard#destroy): wait for close and cleanup listeners #8479
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #8479 +/- ##
==========================================
- Coverage 86.49% 86.29% -0.21%
==========================================
Files 87 87
Lines 8339 8297 -42
Branches 1104 1104
==========================================
- Hits 7213 7160 -53
- Misses 1083 1094 +11
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please describe the changes this PR makes and why it should be merged:
This is yet another attempt at fixing the exact same problem as #8399 and #8405
Status and versioning classification: