fix(Action): Use existing recipients if available

[Jiralite]

Please describe the changes this PR makes and why it should be merged:
This resolves #9624.

The tl;dr of that issue is that when receiving an interaction from a direct message channel with appropriate partials, the recipients array seemed to be absent and fetching the channel caused an internal crash.

I found that strange, so I looked further into this. Discord does send a recipients array:

{
  type: 1,
  recipients: [
    {
      username: 'jiralite',
      public_flags: 4210944,
      id: '618976181026422814',
      global_name: null,
      discriminator: '0',
      avatar_decoration: null,
      avatar: '6df091f5ebb7f9b9f1b021834f9888e1'
    }
  ],
  last_message_id: '1118964852661158049',
  id: '1074403651738669266',
  flags: 0
}

However, when getChannel() is called in GenericAction:

discord.js/packages/discord.js/src/client/actions/Action.js

Line 42 in b61e4fb

recipients: [data.author ?? data.user ?? { id: data.user_id }],

We only look for an author, a user, or otherwise grab the user id, all of which does not exist on this payload. Checking for data.recipients fixed this issue and DMChannel is instantiated with the received recipients array.

---

There is another case where this could fail with the same intents and partials from the issue, and that's from sending an interaction after deleting a message!

When you delete a message, you receive a very simple payload:

{ id: '1118964852661158049', channel_id: '1074403651738669266' }

This gets included in the cache. Unfortunately, upon sending an interaction, discord.js would crash with the same error due to caching:

discord.js/packages/discord.js/src/client/actions/Action.js

Lines 26 to 32 in b61e4fb

	getPayload(data, manager, id, partialType, cache) {
	const existing = manager.cache.get(id);
	if (!existing && this.client.options.partials.includes(partialType)) {
	return manager._add(data, cache);
	}
	return existing;
	}

existing is truthy as the above payload is in the cache. Therefore, ._add() was not called with the received recipients array. To mitigate this, I've removed the !existing check on the if statement so _add() is always called if a relevant partial is specified. I'm not sure this is the best solution, but it works.

---

Finally, last_message_id was added to the getPayload() call. We receive this as seen from the payload above and as such, makes DMChannel no longer partial from interactions.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)			Jul 9, 2023 7:28pm
discord-js-guide	⬜️ Ignored (Inspect)			Jul 9, 2023 7:28pm

Stale.