Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Create parameter input boxes after save #303

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Conversation

Lhcfl
Copy link
Contributor

@Lhcfl Lhcfl commented Aug 2, 2024

What does this fix?

When creating a data explorer query that includes parameters, the parameter input boxes don’t display until the page is refreshed.

After this commit, when the query is saved, the input boxes will appear.

Screen Record

2024-08-02.215944.mp4

ref: t/113297

What does this fix?
===================

When creating a data explorer query that includes parameters, the
parameter input boxes don’t display until the page is refreshed.

After this commit, when the query is saved, the input boxes will appear.

ref: t/113297
Copy link
Member

@ZogStriP ZogStriP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Any chances you could add a spec to ensure this behavior doesn't break in the future?

@Lhcfl
Copy link
Contributor Author

Lhcfl commented Aug 2, 2024

added!

@Lhcfl Lhcfl merged commit e0bfa66 into main Aug 5, 2024
5 checks passed
@Lhcfl Lhcfl deleted the make-hasParams-computed branch August 5, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants