FIX: Create parameter input boxes after save

assets/javascripts/discourse/models/query.js

@@ -1,3 +1,4 @@
+import { computed } from "@ember/object";
 import RestModel from "discourse/models/rest";
 import getURL from "discourse-common/lib/get-url";
 
@@ -23,6 +24,7 @@ export default class Query extends RestModel {
     return getURL(`/admin/plugins/explorer/queries/${this.id}.json?export=1`);
   }
 
+  @computed("param_info")
   get hasParams() {
     return this.param_info.length;
   }

assets/javascripts/discourse/templates/admin/plugins-explorer.hbs

@@ -170,13 +170,15 @@
           <div class="pull-left left-buttons">
             {{#if this.editingQuery}}
               <DButton
+                class="btn-save-query"
                 @action={{this.save}}
                 @label="explorer.save"
                 @disabled={{this.saveDisabled}}
               />
             {{else}}
               {{#unless this.editDisabled}}
                 <DButton
+                  class="btn-edit-query"
                   @action={{this.editQuery}}
                   @label="explorer.edit"
                   @icon="pencil-alt"

test/javascripts/acceptance/param-input-test.js

@@ -134,6 +134,19 @@ acceptance("Data Explorer Plugin | Param Input", function (needs) {
             hidden: false,
             user_id: 1,
           },
+          {
+            id: 3,
+            sql: "SELECT 1",
+            name: "Params test",
+            description: "test for params.",
+            param_info: [],
+            created_at: "2021-02-02T12:21:11.449Z",
+            username: "system",
+            group_ids: [41],
+            last_run_at: "2021-02-11T08:29:59.337Z",
+            hidden: false,
+            user_id: -1,
+          },
         ],
       });
     });
@@ -296,6 +309,48 @@ acceptance("Data Explorer Plugin | Param Input", function (needs) {
         ],
       });
     });
+
+    server.get("/admin/plugins/explorer/queries/3", () => {
+      return helper.response({
+        query: {
+          id: 3,
+          sql: "SELECT 1",
+          name: "Params test",
+          description: "test for params.",
+          param_info: [],
+          created_at: "2021-02-02T12:21:11.449Z",
+          username: "system",
+          group_ids: [41],
+          last_run_at: "2021-02-11T08:29:59.337Z",
+          hidden: false,
+          user_id: -1,
+        },
+      });
+    });
+    server.put("/admin/plugins/explorer/queries/3", () => {
+      return helper.response({
+        query: {
+          id: 3,
+          sql: "-- [params]\n-- int :months_ago = 1\n\nSELECT 1",
+          name: "Params test",
+          description: "test for params.",
+          param_info: [
+            {
+              identifier: "months_ago",
+              type: "int",
+              default: "1",
+              nullable: false,
+            },
+          ],
+          created_at: "2021-02-02T12:21:11.449Z",
+          username: "system",
+          group_ids: [41],
+          last_run_at: "2021-02-11T08:29:59.337Z",
+          hidden: false,
+          user_id: -1,
+        },
+      });
+    });
   });
 
   test("it puts params for the query into the url", async function (assert) {
@@ -339,4 +394,17 @@ acceptance("Data Explorer Plugin | Param Input", function (needs) {
     await click("form.query-run button");
     assert.equal(query(".query-params input").value, monthsAgoValue);
   });
+
+  test("it creates input boxes if has parameters when save", async function (assert) {
+    await visit("/admin/plugins/explorer?id=3");
+    assert.notOk(exists(".query-params input"));
+    await click(".query-edit .btn-edit-query");
+    await click(".query-editor .ace_text-input");
+    await fillIn(
+      ".query-editor .ace_text-input",
+      "-- [params]\n-- int :months_ago = 1\n\nSELECT 1"
+    );
+    await click(".query-edit .btn-save-query");
+    assert.ok(exists(".query-params input"));
+  });
 });