Test on Java 11 #106
Test on Java 11 #106
Conversation
.travis.yml
Outdated
| - jdk: openjdk8 | ||
| env: JAVA_RELEASE=8 JAVA_VERSION=1.8 SCALA_VERSION=2.11 NO_GCE_CHECK=true | ||
| - jdk: openjdk11 | ||
| env: JAVA_RELEASE=11 JAVA_VERSION=11 SCALA_VERSION=2.12 NO_GCE_CHECK=true |
There was a problem hiding this comment.
you can add a an env: global: block to always hav NO_GCE_CHECK=true without re-specifying it
env:
global:
NO_GCE_CHECK=true
You can probably combine that onto a single line but I'm never that clear about yaml syntax...
There was a problem hiding this comment.
Thanks for the suggestion - I'll try that.
| script: | ||
| - mvn -B verify -Ddisq.test.real.world.files.dir=$TRAVIS_BUILD_DIR/gatk/src/test/resources/large -Ddisq.test.real.world.files.ref=$TRAVIS_BUILD_DIR/gatk/src/test/resources/large/human_g1k_v37.20.21.fasta -Ddisq.samtools.bin=/usr/bin/samtools -Ddisq.bcftools.bin=/usr/bin/bcftools | ||
| - mvn -B verify -Djava.release=$JAVA_RELEASE -Djava.version=$JAVA_VERSION -Dscala.version=$SCALA_VERSION -Ddisq.test.real.world.files.dir=$TRAVIS_BUILD_DIR/gatk/src/test/resources/large -Ddisq.test.real.world.files.ref=$TRAVIS_BUILD_DIR/gatk/src/test/resources/large/human_g1k_v37.20.21.fasta -Ddisq.samtools.bin=/usr/bin/samtools -Ddisq.bcftools.bin=/usr/bin/bcftools |
There was a problem hiding this comment.
I hate that it's sometimes 1.8 and sometimes 8, but what can you do...
| @@ -30,15 +30,17 @@ | |||
| </developers> | |||
|
|
|||
| <properties> | |||
| <maven.compiler.target>1.8</maven.compiler.target> | |||
| <maven.compiler.source>1.8</maven.compiler.source> | |||
| <java.release>8</java.release> | |||
There was a problem hiding this comment.
I assume that if you specify a property on the command line it automatically overrules the one that's included in the file?
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> |
There was a problem hiding this comment.
Dumb maven question: why do we need a java11 profile? to specify a different compiler plugin?
There was a problem hiding this comment.
It's to set the maven-compiler-plugin's release configuration property. Annoyingly this is not recognized by the Java 8 compiler, so it can only be set in the Java 11 configuration. Using a profile was the only way I could see to do this.
This change runs all the tests on Travis using Java 11 (in addition to the existing Java 8 tests).